Remove RetainedSyntaxArena

Author: plemarquand

Sources/SwiftSyntax/Identifier.swift

@@ -20,40 +20,31 @@ public struct Identifier: Equatable, Hashable, Sendable {
   @_spi(RawSyntax)
   public let raw: RawIdentifier
 
+  private let arena: SyntaxArenaRef
+
   public init?(_ token: TokenSyntax) {
     guard case .identifier = token.tokenKind else {
       return nil
     }
 
     self.raw = RawIdentifier(token.tokenView)
+    self.arena = token.tokenView.raw.arenaReference
   }
 }
 
 @_spi(RawSyntax)
 public struct RawIdentifier: Equatable, Hashable, Sendable {
   public let name: SyntaxText
 
-  private let arena: RetainedSyntaxArena
-
   @_spi(RawSyntax)
   fileprivate init(_ raw: RawSyntaxTokenView) {
     let backtick = SyntaxText("`")
-    let arena = SyntaxArena()
     if raw.rawText.count > 2 && raw.rawText.hasPrefix(backtick) && raw.rawText.hasSuffix(backtick) {
       let startIndex = raw.rawText.index(after: raw.rawText.startIndex)
       let endIndex = raw.rawText.index(before: raw.rawText.endIndex)
       self.name = SyntaxText(rebasing: raw.rawText[startIndex..<endIndex])
     } else {
       self.name = raw.rawText
     }
-    self.arena = raw.raw.arenaReference.retained
-  }
-
-  public static func == (lhs: RawIdentifier, rhs: RawIdentifier) -> Bool {
-    lhs.name == rhs.name
-  }
-
-  public func hash(into hasher: inout Hasher) {
-    hasher.combine(name)
   }
 }

Tests/SwiftSyntaxTest/IdentifierTests.swift

@@ -36,9 +36,11 @@ class IdentifierTests: XCTestCase {
     XCTAssertEqual(Identifier(unicodeNormalizedToken)?.name, "\u{61}\u{300}")  // "à"
   }
 
-  public func testRawIdentifier() {
-    let rawIdentifier = TokenSyntax(stringLiteral: "sometoken").identifier?.raw
-    XCTAssertEqual(rawIdentifier?.name, SyntaxText("sometoken"))
+  public func testIdentifier() {
+    let token = TokenSyntax(stringLiteral: "sometoken")
+    withExtendedLifetime(token) { token in
+      XCTAssertEqual(token.identifier?.raw.name, SyntaxText("sometoken"))
+    }
   }
 
   public func testTokenSyntaxIdentifier() throws {