Address review comments

Author: iCharlesHu

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,27 @@
+---
+name: Bug report
+about: Create a report to help us improve Subprocess
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. What executable was running?
+2. What arguments are passed in?
+3. What environment values are used?
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Environment (please complete the following information):**
+ - OS [e.g. macOS 15]
+ - Swift version (run `swift --version`) [e.g. swiftlang-6.2.0.1.23 clang-1700.3.1.3]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for Subprocess future directions
+title: "[Feature] Feature Request"
+labels: enhancement
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.spi.yml

@@ -0,0 +1,4 @@
+version: 1
+builder:
+  configs:
+    - documentation_targets: [Subprocess]

CODE_OF_CONDUCT.md

@@ -2,4 +2,4 @@
 
 The code of conduct for this project can be found at https://swift.org/code-of-conduct.
 
-<!-- Copyright (c) 2024 Apple Inc and the Swift Project authors. All Rights Reserved. -->
+<!-- Copyright (c) 2025 Apple Inc and the Swift Project authors. All Rights Reserved. -->

Package.swift

@@ -31,7 +31,7 @@ defaultTraits.insert("SubprocessSpan")
 
 let package = Package(
     name: "Subprocess",
-    platforms: [.macOS("15.0"), .iOS("18.0"), .tvOS("18.0"), .watchOS("11.0")],
+    platforms: [.macOS(.v13)],
     products: [
         .library(
             name: "Subprocess",

Package@swift-6.0.swift

@@ -9,7 +9,7 @@ let availabilityMacro: SwiftSetting = .enableExperimentalFeature(
 
 let package = Package(
     name: "Subprocess",
-    platforms: [.macOS("15.0"), .iOS("18.0"), .tvOS("18.0"), .watchOS("11.0")],
+    platforms: [.macOS(.v13)],
     products: [
         .library(
             name: "Subprocess",

README.md

@@ -4,19 +4,18 @@
 
 Subprocess is a cross-platform package for spawning processes in Swift.
 
-It's like [Foundation.Process](https://developer.apple.com/documentation/foundation/process), but written for Swift and build on top of structural concurrency.
-
 
 ## Getting Started
 
-Subprocess uses [SwiftPM](https://swift.org/package-manager/) as its build tool, so we recommend using that as well. If you want to depend on Subprocess in your own project, it's as simple as adding a `dependencies` clause to your `Package.swift`:
+To use `Subprocess` in a [SwiftPM](https://swift.org/package-manager/) project, add it as a package dependency to your `Package.swift`:
+
 
 ```swift
 dependencies: [
-    .package(url: "https://github.com/iCharlesHu/Subprocess.git", branch: "main")
+    .package(url: "https://github.com/swiftlang/swift-subprocess.git", branch: "main")
 ]
 ```
-and then adding the `Subprocess` module to your target dependencies.
+Then, adding the `Subprocess` module to your target dependencies:
 
 ```swift
 .target(
@@ -124,7 +123,7 @@ let result = try await run(
 
 `Subprocess` provides **platform-specific** configuration options, like setting `uid` and `gid` on Unix and adjusting window style on Windows, through the `PlatformOptions` struct. Check out the `PlatformOptions` documentation for a complete list of configurable parameters across different platforms.
 
-Besides these platform-specific settings, `PlatformOptions` also includes an “escape hatch” via a closure. This closure allows you to have access to low level platform specific spawning constructs to perform customizations if `Subprocess` doesn’t have higher-level APIs. 
+`PlatformOptions` also allows access to platform-specific spawning constructs and customizations via a closure.
 
 ```swift
 import Darwin
@@ -153,7 +152,7 @@ let result = try await run(.path("/bin/exe"), platformOptions: platformOptions)
 
 By default, `Subprocess`:
 - Doesn’t send any input to the child process’s standard input
-- Captures the child process’s standard output as a `String`, up to 128kb
+- Captures the child process’s standard output as a `String`, up to 128kB
 - Ignores the child process’s standard error
 
 You can tailor how `Subprocess` handles the standard input, standard output, and standard error by setting the `input`, `output`, and `error` parameters:
@@ -168,7 +167,7 @@ let result = try await run(.name("cat"), input: .string(content, using: UTF8.sel
 let result = try await run(.name("cat"), output: .data, error: .data)
 ```
 
-`Subprocess` ships with these input options:
+`Subprocess` supports these input options:
 
 #### `NoInput`
 
@@ -178,7 +177,7 @@ Use it by setting `.none` for `input`.
 
 #### `FileDescriptorInput`
 
-This option reads input from a specified `FileDescriptor` you provide. If `closeAfterSpawningProcess` is set to `true`, the subprocess will close the file descriptor after spawning. If `false`, you need to close it, even if the subprocess fails to spawn.
+This option reads input from a specified `FileDescriptor`. If `closeAfterSpawningProcess` is set to `true`, the subprocess will close the file descriptor after spawning. If `false`, you are responsible for closing it, even if the subprocess fails to spawn.
 
 Use it by setting `.fileDescriptor(closeAfterSpawningProcess:)` for `input`.
 
@@ -214,7 +213,7 @@ Use it by setting `.asyncSequence` for `input`.
 
 ---
 
-`Subprocess` also ships these output options:
+`Subprocess` also supports these output options:
 
 #### `DiscardedOutput`
 
@@ -247,10 +246,9 @@ This option redirects the child output to the `.standardOutput` or `.standardErr
 
 ### Cross-platform support
 
-`Subprocess` works on all major platforms supported by Swift, including macOS, Linux, and Windows, with feature parity on all platforms as well as platform-specific options for each.
+`Subprocess` works on macOS, Linux, and Windows, with feature parity on all platforms as well as platform-specific options for each.
 
-The table below describes the current level of support that Subprocess has
-for various platforms:
+The table below describes the current level of support that Subprocess has for various platforms:
 
 | **Platform** | **Support Status** |
 |---|---|
@@ -278,13 +276,11 @@ swift package --disable-sandbox preview-documentation --target Subprocess
 
 ## Contributing to Subprocess
 
-Subprocess is part of the Foundation project. We have a dedicated [Foundation Forum][forum] where people can ask and answer questions on how to use or work on this package. It's also a great place to discuss its evolution.
-
-[forum]: https://forums.swift.org/c/related-projects/foundation/
+Subprocess is part of the Foundation project. Discussion and evolution take place on [Swift Foundation Forum](https://forums.swift.org/c/related-projects/foundation/99).
 
 If you find something that looks like a bug, please open a [Bug Report][bugreport]! Fill out as many details as you can.
 
-[bugreport]: https://github.com/iCharlesHu/Subprocess/issues/new?assignees=&labels=bug&template=bug_report.md
+[bugreport]: https://github.com/swiftlang/swift-subprocess/issues/new?assignees=&labels=bug&template=bug_report.md
 
 <p align="right">(<a href="#readme-top">back to top</a>)</p>
 
@@ -298,8 +294,9 @@ Like all Swift.org projects, we would like the Subprocess project to foster a di
 
 ## Contact information
 
-The current code owner of this package is Charles Hu ([@iCharlesHu](https://github.com/iCharlesHu)). You can contact him [on the Swift forums](https://forums.swift.org/u/icharleshu/summary).
+The Foundation Workgroup communicates with the broader Swift community using the [forum](https://forums.swift.org/c/related-projects/foundation/99) for general discussions.
+
+The workgroup can also be contacted privately by messaging [@foundation-workgroup](https://forums.swift.org/new-message?groupname=foundation-workgroup) on the Swift Forums.
 
-In case of moderation issues, you can also directly contact a member of the [Swift Core Team](https://swift.org/community/#community-structure).
 
 <p align="right">(<a href="#readme-top">back to top</a>)</p>

Sources/Subprocess/API.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information

Sources/Subprocess/AsyncBufferSequence.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -63,15 +63,40 @@ internal struct AsyncBufferSequence: AsyncSequence, Sendable {
     }
 }
 
-extension RangeReplaceableCollection {
-    /// Creates a new instance of a collection containing the elements of an asynchronous sequence.
-    ///
-    /// - Parameter source: The asynchronous sequence of elements for the new collection.
-    @inlinable
-    internal init<Source: AsyncSequence>(_ source: Source) async rethrows where Source.Element == Element {
-        self.init()
-        for try await item in source {
-            append(item)
-        }
-    }
+// MARK: - Page Size
+import _SubprocessCShims
+
+#if canImport(Darwin)
+import Darwin
+internal import MachO.dyld
+
+private let _pageSize: Int = {
+    Int(_subprocess_vm_size())
+}()
+#elseif canImport(WinSDK)
+import WinSDK
+private let _pageSize: Int = {
+    var sysInfo: SYSTEM_INFO = SYSTEM_INFO()
+    GetSystemInfo(&sysInfo)
+    return Int(sysInfo.dwPageSize)
+}()
+#elseif os(WASI)
+// WebAssembly defines a fixed page size
+private let _pageSize: Int = 65_536
+#elseif canImport(Android)
+@preconcurrency import Android
+private let _pageSize: Int = Int(getpagesize())
+#elseif canImport(Glibc)
+@preconcurrency import Glibc
+private let _pageSize: Int = Int(getpagesize())
+#elseif canImport(Musl)
+@preconcurrency import Musl
+private let _pageSize: Int = Int(getpagesize())
+#elseif canImport(C)
+private let _pageSize: Int = Int(getpagesize())
+#endif  // canImport(Darwin)
+
+@inline(__always)
+internal var readBufferSize: Int {
+    return _pageSize
 }

Sources/Subprocess/Buffer.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -54,6 +54,7 @@ extension SequenceOutput.Buffer {
 @available(SubprocessSpan, *)
 #endif
 extension SequenceOutput.Buffer {
+    #if !SubprocessSpan
     /// Access the raw bytes stored in this buffer
     /// - Parameter body: A closure with an `UnsafeRawBufferPointer` parameter that
     ///   points to the contiguous storage for the type. If no such storage exists,
@@ -63,12 +64,20 @@ extension SequenceOutput.Buffer {
     /// - Returns: The return value, if any, of the body closure parameter.
     public func withUnsafeBytes<ResultType>(
         _ body: (UnsafeRawBufferPointer) throws -> ResultType
+    ) rethrows -> ResultType {
+        return try self._withUnsafeBytes(body)
+    }
+    #endif  // !SubprocessSpan
+
+    internal func _withUnsafeBytes<ResultType>(
+        _ body: (UnsafeRawBufferPointer) throws -> ResultType
     ) rethrows -> ResultType {
         #if os(Windows)
         return try self.data.withUnsafeBytes(body)
         #else
         // Although DispatchData was designed to be uncontiguous, in practice
-        // we found that almost all DispatchData are contiguous.
+        // we found that almost all DispatchData are contiguous. Therefore
+        // we can access this body in O(1) most of the time.
         return try self.data.withUnsafeBytes { ptr in
             let bytes = UnsafeRawBufferPointer(start: ptr, count: self.data.count)
             return try body(bytes)