Skip to content

Commit d76bdea

Browse files
committed
Use one set of strings for the android SDK strings
1 parent b688c30 commit d76bdea

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

platforms/Windows/android_sdk/android_sdk.wxs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,27 @@
22
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
33

44
<?if $(ProductArchitecture) = "aarch64"?>
5+
<?define ArchName = "arm64"?>
56
<?define ArchArchDir = "aarch64"?>
67
<?define ArchTriple = "aarch64-unknown-linux-android"?>
78
<?elseif $(ProductArchitecture) = "x86_64"?>
9+
<?define ArchName = "amd64"?>
810
<?define ArchArchDir = "x86_64"?>
911
<?define ArchTriple = "x86_64-unknown-linux-android"?>
1012
<?elseif $(ProductArchitecture) = "armv7"?>
13+
<?define ArchName = "arm"?>
1114
<?define ArchArchDir = "armv7"?>
1215
<?define ArchTriple = "armv7-unknown-linux-android"?>
1316
<?elseif $(ProductArchitecture) = "i686"?>
17+
<?define ArchName = "x86"?>
1418
<?define ArchArchDir = "i686"?>
1519
<?define ArchTriple = "i686-unknown-linux-android"?>
1620
<?endif?>
1721

1822
<Package
1923
Language="1033"
2024
Manufacturer="!(loc.ManufacturerName)"
21-
Name="!(loc.AndroidSdk_ProductName_$(ProductArchitecture))"
25+
Name="!(loc.Android_Sdk_$(ArchName))"
2226
UpgradeCode="$(AndroidSDKUpgradeCode)"
2327
Version="$(NonSemVerProductVersion)"
2428
Scope="$(PackageScope)">
@@ -487,7 +491,7 @@
487491
</ComponentGroup>
488492

489493
<!-- Features -->
490-
<Feature Id="AndroidSDK" AllowAbsent="no" Title="!(loc.AndroidSdk_ProductName_$(ProductArchitecture))">
494+
<Feature Id="AndroidSDK" AllowAbsent="no" Title="!(loc.Android_Sdk_$(ArchName))">
491495
<ComponentGroupRef Id="XCTest" />
492496
<ComponentGroupRef Id="SwiftRemoteMirror" />
493497
<ComponentGroupRef Id="BlocksRuntime" />

platforms/Windows/shared/swift.en-us.wxl

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,17 @@
1616
<String Id="Sdk_ProductName_arm64" Value="Swift Windows SDK (ARM64)" />
1717
<String Id="Sdk_ProductName_amd64" Value="Swift Windows SDK (AMD64)" />
1818
<String Id="Sdk_ProductName_x86" Value="Swift Windows SDK (X86)" />
19-
<String Id="AndroidSdk_ProductName_aarch64" Value="Swift Android SDK (Arm64)" />
20-
<String Id="AndroidSdk_ProductName_x86_64" Value="Swift Android SDK (AMD64)" />
21-
<String Id="AndroidSdk_ProductName_armv7" Value="Swift Android SDK (ARM)" />
22-
<String Id="AndroidSdk_ProductName_i686" Value="Swift Android SDK (X86)" />
19+
<String Id="Android_Sdk_arm64" Value="Swift Android SDK (ARM64)" />
20+
<String Id="Android_Sdk_amd64" Value="Swift Android SDK (AMD64)" />
21+
<String Id="Android_Sdk_arm" Value="Swift Android SDK (ARM)" />
22+
<String Id="Android_Sdk_x86" Value="Swift Android SDK (X86)" />
2323
<String Id="BundleName" Value="Swift Developer Toolkit" />
2424
<String Id="ManufacturerName" Value="swift.org" />
2525

2626
<String Id="OptionsFeaturesLabel" Value="Feature Selection" />
2727
<String Id="Redist_arm64" Value="Swift Windows Redistributable (ARM64)" />
2828
<String Id="Redist_amd64" Value="Swift Windows Redistributable (AMD64)" />
2929
<String Id="Redist_x86" Value="Swift Windows Redistributable (X86)" />
30-
<String Id="Android_Sdk_arm64" Value="Swift Android SDK (ARM64)" />
31-
<String Id="Android_Sdk_amd64" Value="Swift Android SDK (AMD64)" />
32-
<String Id="Android_Sdk_arm" Value="Swift Android SDK (ARM)" />
33-
<String Id="Android_Sdk_x86" Value="Swift Android SDK (X86)" />
3430

3531
<String Id="Caption" Value="[WixBundleName] Setup" />
3632
<String Id="Title" Value="[WixBundleName]" />

0 commit comments

Comments
 (0)