Skip to content

Commit 36273e6

Browse files
committed
WiX: attach disk IDs on directories when possible
Rather than adding the disk ID to each component we install, prefer to attach to the directory. This simplifies the authoring as these directories are known to be architecture agnostic and shared and we can avoid having to annotate each file.
1 parent fa3419e commit 36273e6

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

platforms/Windows/platforms/windows/windows.wxs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,11 @@
176176
<Directory Id="WindowsExperimentalSDK" Name="WindowsExperimental.sdk">
177177
<Directory Name="usr">
178178
<Directory Name="include">
179-
<Directory Id="WindowsExperimentalSDK_usr_include_Block" Name="Block" />
180-
<Directory Id="WindowsExperimentalSDK_usr_include_dispatch" Name="dispatch" />
181-
<Directory Id="WindowsExperimentalSDK_usr_include_os" Name="os" />
182-
<Directory Id="WindowsExperimentalSDK_usr_include__foundation_unicode" Name="_foundation_unicode" />
183-
<Directory Id="WindowsExperimentalSDK_usr_include__FoundationCShims" Name="_Foundation_CShims" />
179+
<Directory Id="WindowsExperimentalSDK_usr_include_Block" Name="Block" DiskId="5" />
180+
<Directory Id="WindowsExperimentalSDK_usr_include_dispatch" Name="dispatch" DiskId="5" />
181+
<Directory Id="WindowsExperimentalSDK_usr_include_os" Name="os" DiskId="5" />
182+
<Directory Id="WindowsExperimentalSDK_usr_include__foundation_unicode" Name="_foundation_unicode" DiskId="5" />
183+
<Directory Id="WindowsExperimentalSDK_usr_include__FoundationCShims" Name="_Foundation_CShims" DiskId="5" />
184184
</Directory>
185185
<Directory Name="lib">
186186
<Directory Name="swift">
@@ -232,7 +232,7 @@
232232
</Directory>
233233
</Directory>
234234
</Directory>
235-
<Directory Id="WindowsExperimentalSDK_usr_share" Name="share" />
235+
<Directory Id="WindowsExperimentalSDK_usr_share" Name="share" DiskId="5" />
236236
</Directory>
237237
</Directory>
238238
</Directory>
@@ -464,7 +464,7 @@
464464
<?endif?>
465465

466466
<ComponentGroup Id="libBlocksRuntime" Directory="WindowsExperimentalSDK_usr_include_Block">
467-
<Component DiskId="5">
467+
<Component>
468468
<File Source="$(ExperimentalSDKRoot)\usr\include\Block\Block.h" />
469469
</Component>
470470
</ComponentGroup>
@@ -568,16 +568,16 @@
568568
<?include ../CDispatch.wxi?>
569569
<?undef Disk?>
570570

571-
<Component Directory="WindowsExperimentalSDK_usr_include_os" DiskId="5">
571+
<Component Directory="WindowsExperimentalSDK_usr_include_os">
572572
<File Source="$(ExperimentalSDKRoot)\usr\include\os\generic_base.h" />
573573
</Component>
574-
<Component Directory="WindowsExperimentalSDK_usr_include_os" DiskId="5">
574+
<Component Directory="WindowsExperimentalSDK_usr_include_os">
575575
<File Source="$(ExperimentalSDKRoot)\usr\include\os\generic_unix_base.h" />
576576
</Component>
577-
<Component Directory="WindowsExperimentalSDK_usr_include_os" DiskId="5">
577+
<Component Directory="WindowsExperimentalSDK_usr_include_os">
578578
<File Source="$(ExperimentalSDKRoot)\usr\include\os\generic_win_base.h" />
579579
</Component>
580-
<Component Directory="WindowsExperimentalSDK_usr_include_os" DiskId="5">
580+
<Component Directory="WindowsExperimentalSDK_usr_include_os">
581581
<File Source="$(ExperimentalSDKRoot)\usr\include\os\object.h" />
582582
</Component>
583583
</ComponentGroup>
@@ -2794,16 +2794,16 @@
27942794
</ComponentGroup>
27952795

27962796
<ComponentGroup Id="ExperimentalAuxiliaryFiles" Directory="WindowsExperimentalSDK_usr_share">
2797-
<Component DiskId="5">
2797+
<Component>
27982798
<File Source="$(ExperimentalSDKRoot)\usr\share\ucrt.modulemap" />
27992799
</Component>
2800-
<Component DiskId="5">
2800+
<Component>
28012801
<File Source="$(ExperimentalSDKRoot)\usr\share\winsdk.modulemap" />
28022802
</Component>
2803-
<Component DiskId="5">
2803+
<Component>
28042804
<File Source="$(ExperimentalSDKRoot)\usr\share\vcruntime.apinotes" />
28052805
</Component>
2806-
<Component DiskId="5">
2806+
<Component>
28072807
<File Source="$(ExperimentalSDKRoot)\usr\share\vcruntime.modulemap" />
28082808
</Component>
28092809
</ComponentGroup>

0 commit comments

Comments
 (0)