Make all Finding.Message extensions file-private.

Now that our tests verify the actual text of the diagnostics, we don't
need these helpers to be visible outside their file. This gets rid of
some noise when you're writing `diagnose` calls in rules because you'll
only see the ones that are relevant.

Author: allevato

Sources/SwiftFormat/PrettyPrint/PrettyPrint.swift

@@ -790,12 +790,12 @@ public class PrettyPrinter {
 }
 
 extension Finding.Message {
-  public static let moveEndOfLineComment: Finding.Message =
+  fileprivate static let moveEndOfLineComment: Finding.Message =
     "move end-of-line comment that exceeds the line length"
 
-  public static let addTrailingComma: Finding.Message =
+  fileprivate static let addTrailingComma: Finding.Message =
     "add trailing comma to the last element in multiline collection literal"
 
-  public static let removeTrailingComma: Finding.Message =
+  fileprivate static let removeTrailingComma: Finding.Message =
     "remove trailing comma from the last element in single line collection literal"
 }

Sources/SwiftFormat/PrettyPrint/WhitespaceLinter.swift

@@ -432,9 +432,9 @@ extension WhitespaceIndentation {
 }
 
 extension Finding.Message {
-  public static let trailingWhitespaceError: Finding.Message = "remove trailing whitespace"
+  fileprivate static let trailingWhitespaceError: Finding.Message = "remove trailing whitespace"
 
-  public static func indentationError(
+  fileprivate static func indentationError(
     expected expectedIndentation: WhitespaceIndentation,
     actual actualIndentation: WhitespaceIndentation
   ) -> Finding.Message {
@@ -470,20 +470,20 @@ extension Finding.Message {
     }
   }
 
-  public static func spacingError(_ spaces: Int) -> Finding.Message {
+  fileprivate static func spacingError(_ spaces: Int) -> Finding.Message {
     let verb = spaces > 0 ? "add" : "remove"
     let noun = abs(spaces) == 1 ? "space" : "spaces"
     return "\(verb) \(abs(spaces)) \(noun)"
   }
 
-  public static let spacingCharError: Finding.Message = "use spaces for spacing"
+  fileprivate static let spacingCharError: Finding.Message = "use spaces for spacing"
 
-  public static let removeLineError: Finding.Message = "remove line break"
+  fileprivate static let removeLineError: Finding.Message = "remove line break"
 
-  public static func addLinesError(_ lines: Int) -> Finding.Message {
+  fileprivate static func addLinesError(_ lines: Int) -> Finding.Message {
     let noun = lines == 1 ? "break" : "breaks"
     return "add \(lines) line \(noun)"
   }
 
-  public static let lineLengthError: Finding.Message = "line is too long"
+  fileprivate static let lineLengthError: Finding.Message = "line is too long"
 }

Sources/SwiftFormat/Rules/AllPublicDeclarationsHaveDocumentation.swift

@@ -87,8 +87,7 @@ public final class AllPublicDeclarationsHaveDocumentation: SyntaxLintRule {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static func declRequiresComment(_ name: String) -> Finding.Message {
+  fileprivate static func declRequiresComment(_ name: String) -> Finding.Message {
     "add a documentation comment for '\(name)'"
   }
 }

Sources/SwiftFormat/Rules/AlwaysUseLiteralForEmptyCollectionInit.swift

@@ -201,7 +201,9 @@ public final class AlwaysUseLiteralForEmptyCollectionInit : SyntaxFormatRule {
 }
 
 extension Finding.Message {
-  public static func refactorIntoEmptyLiteral(replace: String, with: String) -> Finding.Message {
+  fileprivate static func refactorIntoEmptyLiteral(replace: String, with: String)
+    -> Finding.Message
+  {
     "replace '\(replace)' with '\(with)'"
   }
 }

Sources/SwiftFormat/Rules/AlwaysUseLowerCamelCase.swift

@@ -214,8 +214,7 @@ extension ReturnClauseSyntax {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static func nameMustBeLowerCamelCase(
+  fileprivate static func nameMustBeLowerCamelCase(
     _ name: String, description: String
   ) -> Finding.Message {
     "rename the \(description) '\(name)' using lowerCamelCase"

Sources/SwiftFormat/Rules/AmbiguousTrailingClosureOverload.swift

@@ -73,13 +73,11 @@ public final class AmbiguousTrailingClosureOverload: SyntaxLintRule {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static func ambiguousTrailingClosureOverload(_ decl: String) -> Finding.Message {
+  fileprivate static func ambiguousTrailingClosureOverload(_ decl: String) -> Finding.Message {
     "rename '\(decl)' so it is no longer ambiguous when called with a trailing closure"
   }
 
-  @_spi(Rules)
-  public static func otherAmbiguousOverloadHere(_ decl: String) -> Finding.Message {
+  fileprivate static func otherAmbiguousOverloadHere(_ decl: String) -> Finding.Message {
     "ambiguous overload '\(decl)' is here"
   }
 }

Sources/SwiftFormat/Rules/BeginDocumentationCommentWithOneLineSummary.swift

@@ -195,15 +195,13 @@ public final class BeginDocumentationCommentWithOneLineSummary: SyntaxLintRule {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static func terminateSentenceWithPeriod<Sentence: StringProtocol>(_ text: Sentence)
+  fileprivate static func terminateSentenceWithPeriod<Sentence: StringProtocol>(_ text: Sentence)
     -> Finding.Message
   {
     "terminate this sentence with a period: \"\(text)\""
   }
 
-  @_spi(Rules)
-  public static func addBlankLineAfterFirstSentence<Sentence: StringProtocol>(_ text: Sentence)
+  fileprivate static func addBlankLineAfterFirstSentence<Sentence: StringProtocol>(_ text: Sentence)
     -> Finding.Message
   {
     "add a blank comment line after this sentence: \"\(text)\""

Sources/SwiftFormat/Rules/DoNotUseSemicolons.swift

@@ -111,10 +111,8 @@ public final class DoNotUseSemicolons: SyntaxFormatRule {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static let removeSemicolon: Finding.Message = "remove ';'"
+  fileprivate static let removeSemicolon: Finding.Message = "remove ';'"
 
-  @_spi(Rules)
-  public static let removeSemicolonAndMove: Finding.Message =
+  fileprivate static let removeSemicolonAndMove: Finding.Message =
     "remove ';' and move the next statement to a new line"
 }

Sources/SwiftFormat/Rules/DontRepeatTypeInStaticProperties.swift

@@ -106,8 +106,7 @@ public final class DontRepeatTypeInStaticProperties: SyntaxLintRule {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static func removeTypeFromName(name: String, type: Substring) -> Finding.Message {
+  fileprivate static func removeTypeFromName(name: String, type: Substring) -> Finding.Message {
     "remove the suffix '\(type)' from the name of the variable '\(name)'"
   }
 }

Sources/SwiftFormat/Rules/FileScopedDeclarationPrivacy.swift

@@ -160,11 +160,9 @@ public final class FileScopedDeclarationPrivacy: SyntaxFormatRule {
 }
 
 extension Finding.Message {
-  @_spi(Rules)
-  public static let replacePrivateWithFileprivate: Finding.Message =
+  fileprivate static let replacePrivateWithFileprivate: Finding.Message =
     "replace 'private' with 'fileprivate' on file-scoped declarations"
 
-  @_spi(Rules)
-  public static let replaceFileprivateWithPrivate: Finding.Message =
+  fileprivate static let replaceFileprivateWithPrivate: Finding.Message =
     "replace 'fileprivate' with 'private' on file-scoped declarations"
 }