Skip to content

Commit 4819c12

Browse files
committed
Review feedback
1 parent f119329 commit 4819c12

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

proposals/testing/NNNN-targeted-interoperability-swift-testing-and-xctest.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ test skip, providing a clear indication that migration is needed.
8181

8282
> [!NOTE]
8383
> This proposal refers to XCTest in the abstract. There are two different
84-
> implementations of XCTest: the open source [Corelibs XCTest][] and a
84+
> implementations of XCTest: the open source [swift-corelibs-xctest][] and a
8585
> [proprietary XCTest][Xcode XCTest] that is shipped as part of Xcode. The Swift
8686
> evolution process governs changes to the former only. Therefore,
8787
> this proposal is targeted for Corelibs XCTest.
8888
89-
[Corelibs XCTest]: https://github.com/swiftlang/swift-corelibs-xctest
89+
[swift-corelibs-xctest]: https://github.com/swiftlang/swift-corelibs-xctest
9090
[Xcode XCTest]: https://developer.apple.com/documentation/xctest
9191

9292
### Highlight and support XCTest APIs which are lossy without interop
@@ -97,7 +97,6 @@ We propose supporting the following XCTest APIs in Swift Testing:
9797
`XCTFail`
9898
- [Expected failures][], such as `XCTExpectFailure`: marking a Swift Testing
9999
issue in this way will generate a runtime warning issue.
100-
- [`XCTAttachment`][XCTest attachments]
101100
- [Issue handling traits][]: we will make our best effort to translate issues
102101
from XCTest to Swift Testing. For issue details unique to XCTest, we will
103102
include them as a comment when constructing the Swift Testing issue.
@@ -131,7 +130,6 @@ We propose supporting the following Swift Testing APIs in XCTest:
131130
- Includes [exit testing][]
132131
- `withKnownIssue`: marking an XCTest issue in this way will generate a runtime
133132
warning issue. In strict interop mode, this becomes a `fatalError`.
134-
- Attachments
135133
- [Test cancellation][] (currently pitched)
136134

137135
We think developers will find utility in using Swift Testing APIs in XCTest. For
@@ -297,7 +295,6 @@ the proposal.
297295

298296
<!-- XCTest -->
299297
[XCTest assertions]: https://developer.apple.com/documentation/xctest/equality-and-inequality-assertions
300-
[XCTest attachments]: https://developer.apple.com/documentation/xctest/adding-attachments-to-tests-activities-and-issues
301298
[unconditional failure]: https://developer.apple.com/documentation/xctest/unconditional-test-failures
302299
[expected failures]: https://developer.apple.com/documentation/xctest/expected-failures
303300
<!-- Swift Testing -->

0 commit comments

Comments
 (0)