Skip to content

Commit 3df93b7

Browse files
committed
Polling Confirmations: Add a couple sentences on why pollingInterval must be positive
1 parent 1221341 commit 3df93b7

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

proposals/testing/NNNN-polling-confirmations.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,14 @@ well under a millisecond. Because of this, we decided to add on the polling
393393
interval argument: a minimum duration to wait between polling, to make it much
394394
easier for test authors to predict a good-enough guess for when to stop polling.
395395

396+
### Allow `pollingInterval` to be `.zero`
397+
398+
We could allow test authors to set `pollingInterval` as `Duration.zero`, making
399+
polling behave as if only polling iterations is counted.
400+
We chose not to allow this for the same reason we chose to add a wait between
401+
polling: this makes it much easier for test authors to predict when to stop
402+
polling.
403+
396404
### Use macros instead of functions
397405

398406
Instead of adding new bare functions, polling could be written as additional

0 commit comments

Comments
 (0)