[CAS] Fix the async error handling for makeGlobal()

cachemeifyoucan · cachemeifyoucan · commit db0d94e02571 · 2025-03-27T11:01:58.000-07:00
When makeGlobal failed, it accidentally callbacks the async function
twice with the second time being success case.

rdar://147955776
diff --git a/Sources/SwiftDriver/SwiftScan/SwiftScanCAS.swift b/Sources/SwiftDriver/SwiftScan/SwiftScanCAS.swift
@@ -59,8 +59,9 @@ public final class CachedCompilation {
         } else {
           obj.callback(DependencyScanningError.casError("unknown makeGlobal error"))
         }
+      } else {
+        obj.callback(nil)
       }
-      obj.callback(nil)
     }
 
     let context = CallbackContext(self, callback)

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,9 @@ public final class CachedCompilation {`
`59`	`59`	`} else {`
`60`	`60`	`obj.callback(DependencyScanningError.casError("unknown makeGlobal error"))`
`61`	`61`	`}`
	`62`	`+ } else {`
	`63`	`+ obj.callback(nil)`
`62`	`64`	`}`
`63`		`- obj.callback(nil)`
`64`	`65`	`}`
`65`	`66`
`66`	`67`	`let context = CallbackContext(self, callback)`