-
Notifications
You must be signed in to change notification settings - Fork 166
Add a public initializer to RenderContentMetadata #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
d-ronnqvist
merged 6 commits into
swiftlang:main
from
patshaughnessy:r164210651-add-public-initializer-RenderContentMetadata
Nov 12, 2025
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
250486a
Add a public initializer to RenderContentMetadata
patshaughnessy ef63229
Update Sources/SwiftDocC/Model/Rendering/Content/RenderContentMetadat…
patshaughnessy c587ac9
Introduce PublicAPITests for verifying certain API are actually public.
patshaughnessy dae3e09
Merge branch 'main' into r164210651-add-public-initializer-RenderCont…
patshaughnessy d1d964a
Remove unneeded unit test in PublicAPITests.swift.
patshaughnessy 69c18f5
Merge branch 'main' into r164210651-add-public-initializer-RenderCont…
d-ronnqvist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
Tests/SwiftDocCTests/Model/RenderContentMetadataInitializerTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| This source file is part of the Swift.org open source project | ||
|
|
||
| Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| Licensed under Apache License v2.0 with Runtime Library Exception | ||
|
|
||
| See https://swift.org/LICENSE.txt for license information | ||
| See https://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
| */ | ||
|
|
||
| // Import SwiftDocC without the @testable annotation, so we can test there | ||
| // is a public initializer for RenderContentMetadata. | ||
| import SwiftDocC | ||
| import XCTest | ||
|
|
||
| class RenderContentMetadataInitializerTests: XCTestCase { | ||
| func testMetadataPublicInitializer() throws { | ||
| let metadata = RenderContentMetadata( | ||
| anchor: "anchor", | ||
| title: "title", | ||
| abstract: [], | ||
| deviceFrame: "device frame" | ||
| ) | ||
|
|
||
| XCTAssertNotNil(metadata) | ||
| XCTAssertEqual("anchor", metadata.anchor) | ||
| XCTAssertEqual("title", metadata.title) | ||
| XCTAssertEqual([], metadata.abstract) | ||
| XCTAssertEqual("device frame", metadata.deviceFrame) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.