Fix regression where external links are rendering as plaintext (#886)

Resolves: rdar://133444687

Author: mportiz08

src/mixins/referencesProvider.js

@@ -9,6 +9,11 @@
 */
 import AppStore from 'docc-render/stores/AppStore';
 
+const TopicReferenceTypes = new Set([
+  'section',
+  'topic',
+]);
+
 export default {
   // inject the `store`
   inject: {
@@ -32,14 +37,18 @@ export default {
           state: { references: originalRefs = {} },
         },
       } = this;
-      // strip the `url` key from refs if their identifier comes from an
-      // archive that hasn't been included by DocC
+      // strip the `url` key from "topic"/"section" refs if their identifier
+      // comes from an archive that hasn't been included by DocC
       return Object.keys(originalRefs).reduce((newRefs, id) => {
-        const { url, ...refWithoutUrl } = originalRefs[id];
-        return {
+        const originalRef = originalRefs[id];
+        const { url, ...refWithoutUrl } = originalRef;
+        return TopicReferenceTypes.has(originalRef.type) ? ({
           ...newRefs,
           [id]: isFromIncludedArchive(id) ? originalRefs[id] : refWithoutUrl,
-        };
+        }) : ({
+          ...newRefs,
+          [id]: originalRef,
+        });
       }, {});
     },
   },

tests/unit/mixins/referencesProvider.spec.js

@@ -34,28 +34,39 @@ const aa = {
   identifier: 'doc://A/documentation/A/a',
   url: '/documentation/A/a',
   title: 'A.A',
+  type: 'topic',
 };
 const ab = {
   identifier: 'doc://A/documentation/A/b',
   url: '/documentation/A/b',
   title: 'A.B',
+  type: 'topic',
 };
 const bb = {
   identifier: 'doc://B/documentation/B/b',
   url: '/documentation/B/b',
   title: 'B.B',
+  type: 'topic',
 };
 const bbb = {
   identifier: 'doc://BB/documentation/BB/b',
-  url: '/documentation/BB/b',
+  url: '/documentation/BB/b#b',
   title: 'BB.B',
+  type: 'section',
+};
+const c = {
+  identifier: 'https://abc.dev',
+  url: 'https://abc.dev',
+  title: 'C',
+  type: 'link',
 };
 
 const references = {
   [aa.identifier]: aa,
   [ab.identifier]: ab,
   [bb.identifier]: bb,
   [bbb.identifier]: bbb,
+  [c.identifier]: c,
 };
 
 const provide = {
@@ -117,5 +128,6 @@ describe('referencesProvider', () => {
     expect(refs3[bb.identifier].url).toBe(bb.url); // bb still has `url`
     expect(refs3[bbb.identifier].title).toBe(bbb.title);
     expect(refs3[bbb.identifier].url).toBeFalsy(); // bbb `url` is gone now
+    expect(refs3[c.identifier].url).toBe(c.url); // external link untouched
   });
 });