Merge branch 'footnotes-fix-confused-for-link-reference' into all-footnote-fixes

Author: phillmv

src/inlines.c

@@ -1141,6 +1141,13 @@ static cmark_node *handle_close_bracket(cmark_parser *parser, subject *subj) {
       !opener->inl_text->next->next) {
     cmark_chunk *literal = &opener->inl_text->next->as.literal;
     if (literal->len > 1 && literal->data[0] == '^') {
+
+      // Before we got this far, the `handle_close_bracket` function may have
+      // advanced the current state beyond our footnote's actual closing
+      // bracket, ie if it went looking for a `link_label`.
+      // Let's just rewind the subject's position:
+      subj->pos = initial_pos;
+
       inl = make_simple(subj->mem, CMARK_NODE_FOOTNOTE_REFERENCE);
       inl->as.literal = cmark_chunk_dup(literal, 1, literal->len - 1);
       inl->start_line = inl->end_line = subj->line;

test/regression.txt

@@ -272,7 +272,6 @@ Pull request #128 - Buffer overread in tables extension
 
 Footnotes may be nested inside other footnotes.
 
-
 ```````````````````````````````` example footnotes
 This is some text. It has a citation.[^citation]
 
@@ -292,3 +291,25 @@ This is some text. It has a citation.[^citation]
 </ol>
 </section>
 ````````````````````````````````
+
+Footnotes are similar to, but should not be confused with, link references
+
+```````````````````````````````` example footnotes
+This is some text. It has two footnotes references, side-by-side without any spaces,[^footnote1][^footnote2] which are definitely not link references.
+
+[^footnote1]: Hello.
+
+[^footnote2]: Goodbye.
+.
+<p>This is some text. It has two footnotes references, side-by-side without any spaces,<sup class="footnote-ref"><a href="#fn1" id="fnref1">1</a></sup><sup class="footnote-ref"><a href="#fn2" id="fnref2">2</a></sup> which are definitely not link references.</p>
+<section class="footnotes">
+<ol>
+<li id="fn1">
+<p>Hello. <a href="#fnref1" class="footnote-backref">↩</a></p>
+</li>
+<li id="fn2">
+<p>Goodbye. <a href="#fnref2" class="footnote-backref">↩</a></p>
+</li>
+</ol>
+</section>
+````````````````````````````````