Merge pull request #592 from swiftlang/owenv/cache-availability-cleanup

Cleanup compilation caching feature availability flags

Author: owenv

Sources/SWBCore/Extensions/FeatureAvailabilityExtension.swift

@@ -21,5 +21,4 @@ public struct FeatureAvailabilityExtensionPoint: ExtensionPoint {
 }
 
 public protocol FeatureAvailabilityExtension: Sendable {
-    var supportsCompilationCaching: Bool { get }
 }

Sources/SWBCore/Settings/Settings.swift

@@ -764,15 +764,6 @@ public final class Settings: PlatformBuildContext, Sendable {
             (scope.evaluate(BuiltinMacros.IS_ZIPPERED) && scope.evaluate(BuiltinMacros.INDEX_ENABLE_BUILD_ARENA))
     }
 
-    public static func supportsCompilationCaching(_ core: Core) -> Bool {
-        @preconcurrency @PluginExtensionSystemActor func featureAvailabilityExtensions() -> [any FeatureAvailabilityExtensionPoint.ExtensionProtocol] {
-            core.pluginManager.extensions(of: FeatureAvailabilityExtensionPoint.self)
-        }
-        return featureAvailabilityExtensions().contains {
-            $0.supportsCompilationCaching
-        }
-    }
-
     public var enableTargetPlatformSpecialization: Bool {
         return Settings.targetPlatformSpecializationEnabled(scope: globalScope)
     }

Sources/SWBCore/SpecImplementations/Tools/CCompiler.swift

@@ -824,8 +824,6 @@ public class ClangCompilerSpec : CompilerSpec, SpecIdentifierType, GCCCompatible
         language: GCCCompatibleLanguageDialect,
         clangInfo: DiscoveredClangToolSpecInfo?
     ) -> Bool {
-        guard cbc.producer.supportsCompilationCaching else { return false }
-
         // Disabling compilation caching for index build, for now.
         guard !cbc.scope.evaluate(BuiltinMacros.INDEX_ENABLE_BUILD_ARENA) else {
             return false

Sources/SWBCore/SpecImplementations/Tools/SwiftCompiler.swift

@@ -1414,8 +1414,6 @@ public final class SwiftCompilerSpec : CompilerSpec, SpecIdentifierType, SwiftDi
     }
 
     private func swiftCachingEnabled(_ cbc: CommandBuildContext, _ delegate: any TaskGenerationDelegate, _ moduleName: String, _ useIntegratedDriver: Bool, _ explicitModuleBuildEnabled: Bool, _ disabledPCHCompile: Bool) async -> Bool {
-        guard cbc.producer.supportsCompilationCaching else { return false }
-
         guard cbc.scope.evaluate(BuiltinMacros.SWIFT_ENABLE_COMPILE_CACHE) else {
             return false
         }

Sources/SWBCore/TaskGeneration.swift

@@ -264,8 +264,6 @@ public protocol CommandProducer: PlatformBuildContext, SpecLookupContext, Refere
 
     var targetShouldBuildModuleForInstallAPI: Bool { get }
 
-    var supportsCompilationCaching: Bool { get }
-
     func lookupLibclang(path: Path) -> (libclang: Libclang?, version: Version?)
 
     var userPreferences: UserPreferences { get }

Sources/SWBTaskConstruction/TaskProducers/TaskProducer.swift

@@ -1390,10 +1390,6 @@ extension TaskProducerContext: CommandProducer {
         return globalProductPlan.targetsWhichShouldBuildModulesDuringInstallAPI?.contains(configuredTarget) ?? false
     }
 
-    public var supportsCompilationCaching: Bool {
-        return Settings.supportsCompilationCaching(workspaceContext.core)
-    }
-
     public var systemInfo: SystemInfo? {
         return workspaceContext.systemInfo
     }

Sources/SWBTaskExecution/BuildDescriptionManager.swift

@@ -183,7 +183,7 @@ package final class BuildDescriptionManager: Sendable {
 
         var casValidationInfos: OrderedSet<BuildDescription.CASValidationInfo> = []
         let buildGraph = planRequest.buildGraph
-        let shouldValidateCAS = Settings.supportsCompilationCaching(plan.workspaceContext.core) && UserDefaults.enableCASValidation
+        let shouldValidateCAS = UserDefaults.enableCASValidation
 
         // Add the SFR identifier for target-independent tasks.
         staleFileRemovalIdentifierPerTarget[nil] = plan.staleFileRemovalTaskIdentifier(for: nil)

Sources/SWBTestSupport/CoreBasedTests.swift

@@ -243,14 +243,6 @@ extension CoreBasedTests {
         }
     }
 
-    /// If compilation caching is supported.
-    package var supportsCompilationCaching: Bool {
-        get async throws {
-            let core = try await getCore()
-            return Settings.supportsCompilationCaching(core)
-        }
-    }
-
     package var supportsSDKImports: Bool {
         get async throws {
             #if os(macOS)

Sources/SWBTestSupport/DummyCommandProducer.swift

@@ -229,10 +229,6 @@ package struct MockCommandProducer: CommandProducer, Sendable {
         false
     }
 
-    package var supportsCompilationCaching: Bool {
-        false
-    }
-
     package var systemInfo: SystemInfo? {
         return nil
     }

Sources/SWBTestSupport/SkippedTestSupport.swift

@@ -367,12 +367,6 @@ extension Trait where Self == Testing.ConditionTrait {
         }
     }
 
-    package static var requireCompilationCaching: Self {
-        enabled("compilation caching is not supported") {
-            try await ConditionTraitContext.shared.supportsCompilationCaching
-        }
-    }
-
     package static var requireDependencyScannerPlusCaching: Self {
         disabled {
             let libclang = try #require(try await ConditionTraitContext.shared.libclang)
@@ -397,7 +391,7 @@ extension Trait where Self == Testing.ConditionTrait {
 
     package static var requireCASValidation: Self {
         enabled {
-            guard try await ConditionTraitContext.shared.supportsCompilationCaching, UserDefaults.enableCASValidation else {
+            guard UserDefaults.enableCASValidation else {
                 return false
             }
             guard let path = try? await ConditionTraitContext.shared.llvmCasToolPath else {