Make a couple parameters in the BuildTarget initializer defaulted

Author: ahoppen

Sources/BuildServerProtocol/SupportTypes/BuildTarget.swift

@@ -68,9 +68,9 @@ public struct BuildTarget: Codable, Hashable, Sendable {
 
   public init(
     id: BuildTargetIdentifier,
-    displayName: String?,
-    baseDirectory: URI?,
-    tags: [BuildTargetTag],
+    displayName: String? = nil,
+    baseDirectory: URI? = nil,
+    tags: [BuildTargetTag] = [],
     capabilities: BuildTargetCapabilities,
     languageIds: [Language],
     dependencies: [BuildTargetIdentifier],

Sources/BuildSystemIntegration/FixedCompilationDatabaseBuildSystem.swift

@@ -84,8 +84,6 @@ package actor FixedCompilationDatabaseBuildSystem: BuiltInBuildSystem {
     return WorkspaceBuildTargetsResponse(targets: [
       BuildTarget(
         id: .dummy,
-        displayName: nil,
-        baseDirectory: nil,
         tags: [.test],
         capabilities: BuildTargetCapabilities(),
         // Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/JSONCompilationDatabaseBuildSystem.swift

@@ -102,8 +102,6 @@ package actor JSONCompilationDatabaseBuildSystem: BuiltInBuildSystem {
         }
       return BuildTarget(
         id: try BuildTargetIdentifier.createCompileCommands(compiler: compiler),
-        displayName: nil,
-        baseDirectory: nil,
         tags: [.test],
         capabilities: BuildTargetCapabilities(),
         // Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/LegacyBuildServerBuildSystem.swift

@@ -145,7 +145,6 @@ actor LegacyBuildServerBuildSystem: MessageHandler, BuiltInBuildSystem {
       BuildTarget(
         id: .dummy,
         displayName: "BuildServer",
-        baseDirectory: nil,
         tags: [.test],
         capabilities: BuildTargetCapabilities(),
         // Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift

@@ -512,7 +512,6 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
       return BuildTarget(
         id: targetId,
         displayName: target.name,
-        baseDirectory: nil,
         tags: tags,
         capabilities: BuildTargetCapabilities(),
         // Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.
@@ -526,7 +525,6 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
       BuildTarget(
         id: .forPackageManifest,
         displayName: "Package.swift",
-        baseDirectory: nil,
         tags: [.notBuildable],
         capabilities: BuildTargetCapabilities(),
         languageIds: [.swift],

Sources/SKTestSupport/CustomBuildServerTestProject.swift

@@ -201,9 +201,6 @@ package extension CustomBuildServer {
     return WorkspaceBuildTargetsResponse(targets: [
       BuildTarget(
         id: .dummy,
-        displayName: nil,
-        baseDirectory: nil,
-        tags: [],
         capabilities: BuildTargetCapabilities(),
         languageIds: [],
         dependencies: []