Merge pull request #1843 from ahoppen/empty-path-crash

Don’t crash when opening a file with an empty path

Author: ahoppen

Sources/LanguageServerProtocol/SupportTypes/DocumentURI.swift

@@ -56,8 +56,12 @@ public struct DocumentURI: Codable, Hashable, Sendable {
   /// fallback mode that drops semantic functionality.
   public var pseudoPath: String {
     if storage.isFileURL {
-      return storage.withUnsafeFileSystemRepresentation {
-        String(cString: $0!)
+      return storage.withUnsafeFileSystemRepresentation { filePath in
+        if let filePath {
+          String(cString: filePath)
+        } else {
+          ""
+        }
       }
     } else {
       return storage.absoluteString

Tests/SourceKitLSPTests/LifecycleTests.swift

@@ -164,4 +164,9 @@ final class LifecycleTests: XCTestCase {
       )
     )
   }
+
+  func testOpenFileWithoutPath() async throws {
+    let testClient = try await TestSourceKitLSPClient()
+    testClient.openDocument("", uri: DocumentURI(try XCTUnwrap(URL(string: "file://"))), language: .swift)
+  }
 }