Merge pull request #2333 from ahoppen/func-prefix

ahoppen · web-flow · commit bee567d14c5a · 2025-10-29T07:09:58.000+01:00
Remove TODO that `filterText` of override completions should not contain `func` in filterText
diff --git a/Tests/SourceKitLSPTests/SwiftCompletionTests.swift b/Tests/SourceKitLSPTests/SwiftCompletionTests.swift
@@ -339,7 +339,6 @@ final class SwiftCompletionTests: XCTestCase {
       XCTFail("No completion item with label 'foo()'")
       return
     }
-    // TODO: The filter text should be "foo()" (https://github.com/swiftlang/sourcekit-lsp/issues/1599)
     XCTAssertEqual(item.filterText, "func foo()")
     XCTAssertEqual(
       item.textEdit,

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,6 @@ final class SwiftCompletionTests: XCTestCase {`
`339`	`339`	`XCTFail("No completion item with label 'foo()'")`
`340`	`340`	`return`
`341`	`341`	`}`
`342`		`- // TODO: The filter text should be "foo()" (https://github.com/swiftlang/sourcekit-lsp/issues/1599)`
`343`	`342`	`XCTAssertEqual(item.filterText, "func foo()")`
`344`	`343`	`XCTAssertEqual(`
`345`	`344`	`item.textEdit,`