Merge pull request #2309 from bnbarham/log-on-absolute-comp-db

Log when absolute compilation DB search paths are skipped

Author: bnbarham

Sources/BuildServerIntegration/DetermineBuildServer.swift

@@ -26,8 +26,10 @@ private func searchForCompilationDatabaseConfig(
   options: SourceKitLSPOptions
 ) -> BuildServerSpec? {
   let searchPaths =
-    (options.compilationDatabaseOrDefault.searchPaths ?? []).compactMap {
-      try? RelativePath(validating: $0)
+    (options.compilationDatabaseOrDefault.searchPaths ?? []).compactMap { searchPath in
+      orLog("Compilation DB search path") {
+        try RelativePath(validating: searchPath)
+      }
     } + [
       // These default search paths match the behavior of `clangd`
       try! RelativePath(validating: "."),

Sources/SourceKitLSP/SourceKitLSPServer.swift

@@ -912,13 +912,7 @@ extension SourceKitLSPServer {
       logger.log("Cannot open workspace before server is initialized")
       throw NoCapabilityRegistryError()
     }
-    let options = SourceKitLSPOptions.merging(
-      base: self.options,
-      override: SourceKitLSPOptions(
-        path: workspaceFolder.fileURL?
-          .appending(components: ".sourcekit-lsp", "config.json")
-      )
-    )
+
     logger.log("Creating workspace at \(workspaceFolder.forLogging)")
     logger.logFullObjectInMultipleLogMessages(header: "Workspace options", options.loggingProxy)