Address review comments to #1326

Author: ahoppen

Sources/SemanticIndex/SemanticIndexManager.swift

@@ -515,6 +515,10 @@ public final actor SemanticIndexManager {
       indexTasks.append(indexTask)
 
       let filesToIndex = targetsBatch.flatMap({ filesByTarget[$0]! })
+      // The number of index tasks that don't currently have an in-progress task associated with it.
+      // The denominator in the index progress should get incremented by this amount.
+      // We don't want to increment the denominator for tasks that already have an index in progress.
+      let newIndexTasks = filesToIndex.filter { inProgressIndexTasks[$0.sourceFile] == nil }.count
       for file in filesToIndex {
         // The state of `inProgressIndexTasks` will get pushed on from `updateIndexStore`.
         // The updates to `inProgressIndexTasks` from `updateIndexStore` cannot race with setting it to
@@ -526,7 +530,7 @@ public final actor SemanticIndexManager {
           indexTask: indexTask
         )
       }
-      indexTasksWereScheduled(filesToIndex.count)
+      indexTasksWereScheduled(newIndexTasks)
     }
     let indexTasksImmutable = indexTasks
 

Sources/SourceKitLSP/IndexProgressManager.swift

@@ -31,6 +31,13 @@ actor IndexProgressManager {
   ///
   /// The number of outstanding tasks is determined from the `scheduled` and `executing` tasks in all the
   /// `SemanticIndexManager`s.
+  ///
+  /// Note that the `queuedIndexTasks` might exceed the number of files in the project, eg. in the following scenario:
+  /// - Schedule indexing of A.swift and B.swift -> 0 / 2
+  /// - Indexing of A.swift finishes -> 1 / 2
+  /// - A.swift is modified and should be indexed again -> 1 / 3
+  /// - B.swift finishes indexing -> 2 / 3
+  /// - A.swift finishes indexing for the second time -> 3 / 3 -> Status disappears
   private var queuedIndexTasks = 0
 
   /// While there are ongoing index tasks, a `WorkDoneProgressManager` that displays the work done progress.