Merge pull request #2124 from MahdiBM/fix-experimenta-features-flag

Fix `experimentalFeatures` command line flag and description

Author: ahoppen

Sources/Diagnose/IndexCommand.swift

@@ -69,10 +69,10 @@ package struct IndexCommand: AsyncParsableCommand {
   var toolchainOverride: String?
 
   @Option(
-    name: .customLong("experimental-index-feature"),
+    name: .customLong("experimental-feature"),
     help: """
       Enable an experimental sourcekit-lsp feature.
-      Available features are: \(ExperimentalFeature.allCases.map(\.rawValue).joined(separator: ", "))
+      Available features are: \(ExperimentalFeature.allNonInternalCases.map(\.rawValue).joined(separator: ", "))
       """
   )
   var experimentalFeatures: [ExperimentalFeature] = []

Sources/SKOptions/ExperimentalFeatures.swift

@@ -44,4 +44,29 @@ public enum ExperimentalFeature: String, Codable, Sendable, CaseIterable {
   ///
   /// - Note: Internal option, for testing only
   case synchronizeForBuildSystemUpdates = "synchronize-for-build-system-updates"
+
+  /// All non-internal experimental features.
+  public static var allNonInternalCases: [ExperimentalFeature] {
+    allCases.filter { !$0.isInternal }
+  }
+
+  /// Whether the feature is internal.
+  var isInternal: Bool {
+    switch self {
+    case .onTypeFormatting:
+      return false
+    case .setOptionsRequest:
+      return true
+    case .sourceKitOptionsRequest:
+      return true
+    case .isIndexingRequest:
+      return true
+    case .structuredLogs:
+      return false
+    case .outputPathsRequest:
+      return true
+    case .synchronizeForBuildSystemUpdates:
+      return true
+    }
+  }
 }

Sources/sourcekit-lsp/SourceKitLSP.swift

@@ -136,7 +136,7 @@ struct SourceKitLSP: AsyncParsableCommand {
     name: .customLong("experimental-feature"),
     help: """
       Enable an experimental sourcekit-lsp feature.
-      Available features are: \(ExperimentalFeature.allCases.map(\.rawValue).joined(separator: ", "))
+      Available features are: \(ExperimentalFeature.allNonInternalCases.map(\.rawValue).joined(separator: ", "))
       """
   )
   var experimentalFeatures: [String] = []