handle unexpected flags

rnro · rnro · commit f857fab8b8a5 · 2024-11-12T15:23:22.000Z
diff --git a/Sources/Memcache/Extensions/ByteBuffer+Memcache.swift b/Sources/Memcache/Extensions/ByteBuffer+Memcache.swift
@@ -157,9 +157,11 @@ extension ByteBuffer {
                 }
             default:
                 // Encountered a character we weren't expecting. This should be a fatal error.
-                fatalError("Unexpected character in flags.")
+                self.moveReaderIndex(forwardBy: 1)
+                print("Unexpected character in flags.") // TODO: decode flags
             }
         }
+        // TODO: flags is not currently populated
         return flags
     }
 }
diff --git a/Tests/SwiftMemcacheTests/UnitTest/MemcacheResponseDecoderTests.swift b/Tests/SwiftMemcacheTests/UnitTest/MemcacheResponseDecoderTests.swift
@@ -36,6 +36,9 @@ final class MemcacheResponseDecoderTests: XCTestCase {
             returnCode = 0x4844
         case .NS:
             returnCode = 0x4E53
+            returnCode = 0x4E53
+        case .ER:
+            returnCode = 0x4552
         case .EX:
             returnCode = 0x4558
         case .NF:

Original file line number	Diff line number	Diff line change
`@@ -157,9 +157,11 @@ extension ByteBuffer {`
`157`	`157`	`}`
`158`	`158`	`default:`
`159`	`159`	`// Encountered a character we weren't expecting. This should be a fatal error.`
`160`		`- fatalError("Unexpected character in flags.")`
	`160`	`+ self.moveReaderIndex(forwardBy: 1)`
	`161`	`+ print("Unexpected character in flags.") // TODO: decode flags`
`161`	`162`	`}`
`162`	`163`	`}`
	`164`	`+ // TODO: flags is not currently populated`
`163`	`165`	`return flags`
`164`	`166`	`}`
`165`	`167`	`}`