Improve Redis Channel Pipeline Debugging

Motivation:

Debugging and properly handling errors was difficult as the `ChannelHandler` names were the default generic names, in addition the `RedisCommandHandler` did not pipe errors further up the pipeline.

Modifications:

`RedisCommandHandler` now calls `context.fireErrorCaught(error)` when receiving errors, and the default Redis `ChannelPipeline` handlers are added with debugging names.

Result:

It should be easier for debugging purposes to work with any Redis `ChannelPipeline`.

Author: Mordil

Sources/NIORedis/ChannelHandlers/RedisCommandHandler.swift

@@ -62,6 +62,7 @@ extension RedisCommandHandler: ChannelInboundHandler {
             return assertionFailure("Received unexpected error while idle: \(error.localizedDescription)")
         }
         leadPromise.fail(error)
+        context.fireErrorCaught(error)
     }
 
     /// Invoked by NIO when a read has been fired from earlier in the response chain. This forwards the unwrapped

Sources/NIORedis/Redis.swift

@@ -36,11 +36,17 @@ extension Redis {
                 ChannelOptions.socket(SocketOptionLevel(SOL_SOCKET), SO_REUSEADDR),
                 value: 1
             )
-            .channelInitializer { $0.pipeline.addHandlers([
-                MessageToByteHandler(RedisMessageEncoder()),
-                ByteToMessageHandler(RedisByteDecoder()),
-                RedisCommandHandler()
-            ])}
+            .channelInitializer { channel in
+                let handlers: [(ChannelHandler, String)] = [
+                    (MessageToByteHandler(RedisMessageEncoder()), "NIORedis.Outgoing"),
+                    (ByteToMessageHandler(RedisByteDecoder()), "NIORedis.Incoming"),
+                    (RedisCommandHandler(), "NIORedis.Queue")
+                ]
+                return .andAllSucceed(
+                    handlers.map { channel.pipeline.addHandler($0, name: $1) },
+                    on: group.next()
+                )
+            }
     }
 }