Fix Data Conversion to RESPValue

Motivation:

`Foundation.Data` was unexpectedly receiving `RESPValueConvertible` conformance through the `Collection` extension which lead to incorrect encoding.

Modifications:

Add explicit conformance to `RESPValueConvertible` for `Data`.

Result:

Users should see their `Data` encoding to RESP format as expected.

Author: Mordil

Sources/RedisNIO/RESP/RESPValue.swift

@@ -24,6 +24,15 @@ extension String {
     }
 }
 
+extension Data {
+    @inline(__always)
+    var byteBuffer: ByteBuffer {
+        var buffer = RESPValue.allocator.buffer(capacity: self.count)
+        buffer.writeBytes(self)
+        return buffer
+    }
+}
+
 /// A representation of a Redis Serialization Protocol (RESP) primitive value.
 ///
 /// See: [https://redis.io/topics/protocol](https://redis.io/topics/protocol)

Sources/RedisNIO/RESP/RESPValueConvertible.swift

@@ -152,3 +152,16 @@ extension Optional: RESPValueConvertible where Wrapped: RESPValueConvertible {
         }
     }
 }
+
+import struct Foundation.Data
+
+extension Data: RESPValueConvertible {
+    public init?(_ value: RESPValue) {
+        guard let data = value.data else { return nil }
+        self = data
+    }
+
+    public func convertedToRESPValue() -> RESPValue {
+        return .bulkString(self.byteBuffer)
+    }
+}

Tests/RedisNIOTests/RESP/RESPTranslatorWritingTests.swift

@@ -64,6 +64,12 @@ final class RESPTranslatorWritingTests: XCTestCase {
         XCTAssertTrue(testPass(input: .null, expected: "$-1\r\n"))
     }
 
+    func testDataEncoding() throws {
+        let name = #function
+        let data = Data(name.bytes).convertedToRESPValue()
+        XCTAssertTrue(testPass(input: data, expected: "$\(name.count)\r\n\(name)\r\n"))
+    }
+
     private func testPass(input: RESPValue, expected: [UInt8]) -> Bool {
         let allocator = ByteBufferAllocator()
 
@@ -97,5 +103,6 @@ extension RESPTranslatorWritingTests {
         ("testArrays", testArrays),
         ("testError", testError),
         ("testNull", testNull),
+        ("testDataEncoding", testDataEncoding),
     ]
 }