Fix clang-20 toolchain with asio-grpc #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReichert
force-pushed
the
rodrigor/llvm-20-asio-grpc
branch
from
e94f5dd to
ba2c6cb
Compare
RReichert
commented
Nov 25, 2025
| flags = [ | ||
| # This is a workaround for memory_resource being experimental only | ||
| # in the llvm-14 libc++ impelmentation. | ||
| "-DSWIFTNAV_EXPERIMENTAL_MEMORY_RESOURCE", |
Contributor
Author
There was a problem hiding this comment.
This preprocessor variable shouldn't be part of clang-20 toolchain, we originally added this to clang-14 because #include <memory_resource> library wasn't available at the time but it was available under <experimental/memory_resource>.
martin4861
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I'm removing a preprocessor variable that was introduced to the clang-20 toolchain which was a temporary hack added to the clang-14 implementation specifically for Orion.
Testing
see https://github.com/swift-nav/orion/pull/9517, previously failing on libc++ stage, now its passing (currently failing on some formatting, which can be ignored).