Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Commit 72f05ff

Browse files
committed
Merge pull request #346 from jacobmcnamee/ref_ecef
Fix uninitialized ref_ecef
2 parents 5cb52a0 + 7010e1d commit 72f05ff

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/dgnss_management.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ void dgnss_update(u8 num_sats, sdiff_t *sdiffs, double receiver_ecef[3],
298298

299299
/* Unless the KF says otherwise, DONT TRUST THE MEASUREMENTS */
300300
u8 is_bad_measurement = true;
301-
302301
double ref_ecef[3];
303302
if (num_sats >= 5) {
304303
double b2[3];
@@ -312,8 +311,6 @@ void dgnss_update(u8 num_sats, sdiff_t *sdiffs, double receiver_ecef[3],
312311
memset(b2, 0, sizeof(b2));
313312
}
314313

315-
double ref_ecef[3];
316-
317314
vector_add_sc(3, receiver_ecef, b2, 0.5, ref_ecef);
318315

319316
/* TODO: make a common DE and use it instead. */
@@ -330,7 +327,6 @@ void dgnss_update(u8 num_sats, sdiff_t *sdiffs, double receiver_ecef[3],
330327
nkf.state_cov_U, nkf.state_cov_D,
331328
is_bad_measurement);
332329

333-
/* TODO: Refactor - looks like ref_ecef can be passed in uninitialized */
334330
if (!is_bad_measurement) {
335331
update_ambiguity_test(ref_ecef,
336332
dgnss_settings.phase_var_test,

0 commit comments

Comments
 (0)