Improve PatchTestOperationFailedException

This adds the failed operation and the actual value that failed the
test operation check to the exception.

Author: jakobw

src/JsonPatch.php

@@ -174,8 +174,7 @@ public function apply(&$original, $stopOnError = true)
                         $diff = new JsonDiff($operation->value, $value,
                             JsonDiff::STOP_ON_DIFF);
                         if ($diff->getDiffCnt() !== 0) {
-                            throw new PatchTestOperationFailedException('Test operation ' . json_encode($operation, JSON_UNESCAPED_SLASHES)
-                                . ' failed: ' . json_encode($value));
+                            throw new PatchTestOperationFailedException($operation, $value);
                         }
                         break;
                 }
@@ -189,4 +188,4 @@ public function apply(&$original, $stopOnError = true)
         }
         return $errors;
     }
-}
+}

src/PatchTestOperationFailedException.php

@@ -3,6 +3,47 @@
 namespace Swaggest\JsonDiff;
 
 
+use Throwable;
+
 class PatchTestOperationFailedException extends Exception
 {
-}
+    /** @var object */
+    private $operation;
+    /** @var string */
+    private $actualValue;
+
+    /**
+     * @param object $operation
+     * @param string $actualValue
+     * @param int $code
+     * @param Throwable|null $previous
+     */
+    public function __construct(
+        $operation,
+        $actualValue,
+        $code = 0,
+        Throwable $previous = null
+    )
+    {
+        parent::__construct('Test operation ' . json_encode($operation, JSON_UNESCAPED_SLASHES)
+            . ' failed: ' . json_encode($actualValue), $code, $previous);
+        $this->operation = $operation;
+        $this->actualValue = $actualValue;
+    }
+
+    /**
+     * @return object
+     */
+    public function getOperation()
+    {
+        return $this->operation;
+    }
+
+    /**
+     * @return string
+     */
+    public function getActualValue()
+    {
+        return $this->actualValue;
+    }
+}

tests/src/JsonPatchTest.php

@@ -162,11 +162,16 @@ public function testApplyNonExistentLevelOne()
 
     public function testTestOperationFailed()
     {
-        $data = array('abc' => 'xyz');
+        $actualValue = 'xyz';
+        $data = array('abc' => $actualValue);
+        $operation = new JsonPatch\Test('/abc', 'def');
+
         $p = new JsonPatch();
-        $p->op(new JsonPatch\Test('/abc', 'def'));
-        $errors = $p->apply($data, false);
-        $this->assertInstanceOf(PatchTestOperationFailedException::class, $errors[0]);
+        $p->op($operation);
+        $testError = $p->apply($data, false)[0];
+        $this->assertInstanceOf(PatchTestOperationFailedException::class, $testError);
+        $this->assertSame($operation, $testError->getOperation());
+        $this->assertSame($actualValue, $testError->getActualValue());
     }
 
 }