fix(http): avoid parsing XML response bodies as YAML (#3986)

* fix(http): avoid parsing XML response bodies as YAML

Closes #3844

---------

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

Author: lukaszzazulak

src/http/serializers/response/index.js

@@ -4,11 +4,13 @@ export const shouldDownloadAsText = (contentType = '') =>
   /(json|xml|yaml|text)\b/.test(contentType);
 
 function parseBody(body, contentType) {
-  if (
-    contentType &&
-    (contentType.indexOf('application/json') === 0 || contentType.indexOf('+json') > 0)
-  ) {
-    return JSON.parse(body);
+  if (contentType) {
+    if (contentType.indexOf('application/json') === 0 || contentType.indexOf('+json') > 0) {
+      return JSON.parse(body);
+    }
+    if (contentType.indexOf('application/xml') === 0 || contentType.indexOf('+xml') > 0) {
+      return body;
+    }
   }
   return jsYaml.load(body);
 }

test/http/index.js

@@ -469,6 +469,23 @@ describe('http', () => {
           expect(resSerialize.data).toBe(body);
         });
     });
+
+    test('should not parse xml response', () => {
+      const headers = { 'Content-Type': 'application/xml' };
+      const body = '<Pet><name>cat: with: colon: and: spaces</name></Pet>';
+      const mockPool = mockAgent.get('http://swagger.io');
+      mockPool.intercept({ path: '/' }).reply(200, body, { headers });
+
+      return fetch('http://swagger.io')
+        .then((_res) =>
+          // eslint-disable-line no-undef
+          serializeResponse(_res, 'https://swagger.io')
+        )
+        .then((resSerialize) => {
+          expect(resSerialize.body).toBe(body);
+          expect(resSerialize.parseError).toBeUndefined();
+        });
+    });
   });
 
   describe('shouldDownloadAsText', () => {