fix: StackOverflowError with recursive data model #4852

Author: ewaostrowska

modules/swagger-core/src/main/java/io/swagger/v3/core/util/PrimitiveType.java

@@ -198,7 +198,7 @@ public DateSchema createProperty() {
         }
         @Override
         public Schema createProperty31() {
-            return new JsonSchema().typesItem("object").type("object").format("date");
+            return new JsonSchema().typesItem("string").type("string").format("date");
         }
     },
     DATE_TIME(java.util.Date.class, "date-time") {
@@ -208,7 +208,7 @@ public DateTimeSchema createProperty() {
         }
         @Override
         public Schema createProperty31() {
-            return new JsonSchema().typesItem("object").type("object").format("date-time");
+            return new JsonSchema().typesItem("string").type("string").format("date-time");
         }
     },
     PARTIAL_TIME(java.time.LocalTime.class, "partial-time") {
@@ -218,7 +218,7 @@ public Schema createProperty() {
         }
         @Override
         public Schema createProperty31() {
-            return new JsonSchema().typesItem("object").type("object").format("partial-time");
+            return new JsonSchema().typesItem("string").type("string").format("partial-time");
         }
     },
     FILE(java.io.File.class, "file") {
@@ -572,7 +572,7 @@ private static <K> void addMultiKeys(Map<K, Collection<PrimitiveType>> map, Prim
         }
     }
 
-    public static class DateStub {
+    private static class DateStub {
         private DateStub() {
         }
     }

modules/swagger-core/src/test/java/io/swagger/v3/core/resolving/Ticket2992Test.java

@@ -18,6 +18,48 @@ public void testLocalTime() throws Exception {
 
         ModelConverterContextImpl context = new ModelConverterContextImpl(modelResolver);
 
+        Schema model = context
+                .resolve(new AnnotatedType(TestObject2992.class));
+
+        SerializationMatchers.assertEqualsToYaml(context.getDefinedModels(), "LocalTime:\n" +
+                "  type: object\n" +
+                "  properties:\n" +
+                "    hour:\n" +
+                "      type: integer\n" +
+                "      format: int32\n" +
+                "    minute:\n" +
+                "      type: integer\n" +
+                "      format: int32\n" +
+                "    second:\n" +
+                "      type: integer\n" +
+                "      format: int32\n" +
+                "    nano:\n" +
+                "      type: integer\n" +
+                "      format: int32\n" +
+                "TestObject2992:\n" +
+                "  type: object\n" +
+                "  properties:\n" +
+                "    name:\n" +
+                "      type: string\n" +
+                "    a:\n" +
+                "      $ref: \"#/components/schemas/LocalTime\"\n" +
+                "    b:\n" +
+                "      $ref: \"#/components/schemas/LocalTime\"\n" +
+                "    c:\n" +
+                "      $ref: \"#/components/schemas/LocalTime\"\n" +
+                "    d:\n" +
+                "      type: string\n" +
+                "      format: date-time\n" +
+                "    e:\n" +
+                "      type: string\n" +
+                "      format: date-time\n" +
+                "    f:\n" +
+                "      type: string\n" +
+                "      format: date-time");
+
+        PrimitiveType.enablePartialTime();
+        context = new ModelConverterContextImpl(modelResolver);
+
         context
                 .resolve(new AnnotatedType(TestObject2992.class));
 

modules/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/APIResponsesResourceTest.java

@@ -55,6 +55,11 @@ private Schema getResponseSchema(String path) {
     public void testSchemaAPIResource31(String schema) {
         Schema responseSchema = getResponseSchema(schema);
 
+        // Debug output for type and types
+        System.out.println("Schema path: " + schema);
+        System.out.println("type: " + responseSchema.getType());
+        System.out.println("types: " + responseSchema.getTypes());
+
         // Value of field "type" must equal value of field "types"
         assertEquals(responseSchema.getType(), responseSchema.getTypes().iterator().next());
     }

modules/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/resources/APIResponsesResource.java

@@ -1,6 +1,5 @@
 package io.swagger.v3.jaxrs2.resources;
 
-import io.swagger.v3.core.util.PrimitiveType;
 import io.swagger.v3.oas.annotations.media.Content;
 import io.swagger.v3.oas.annotations.media.Schema;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
@@ -148,16 +147,6 @@ public void postBigDecimalSchemaContent() { }
     })
     public void postNumberSchemaContent() { }
 
-    @POST
-    @Path("postDateStubSchemaContent")
-    @ApiResponses({
-            @ApiResponse(
-                    responseCode = "200",
-                    content = @Content(schema = @Schema(implementation = PrimitiveType.DateStub.class))
-            )
-    })
-    public void postDateStubSchemaContent() { }
-
     @POST
     @Path("postDateSchemaContent")
     @ApiResponses({