ts: Fix all outstanding biome lint rules (#2072)

Author: svix-mman

codegen/templates/javascript/types/struct.ts.jinja

@@ -5,16 +5,18 @@ import {
     {{ c | to_upper_camel_case }}Serializer,
 } from './{{ c | to_lower_camel_case }}';
 {% endfor -%}
-
 {% set type_name = type.name | to_upper_camel_case %}
 
+{% if type.fields | length == 0 %}// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat{% endif %}
+
 {{ doc_comment }}
 export interface {{ type_name }} {
     {% include "types/struct_fields.ts.jinja" -%}
 }
 
 export const {{ type_name }}Serializer = {
-    _fromJsonObject(object: any): {{ type_name }} {
+    {% set underscore_prefix %}{% if type.fields | length == 0%}_{% endif %}{% endset -%}
+    _fromJsonObject({{ underscore_prefix }}object: any): {{ type_name }} {
         return {
             {% for field in type.fields -%}
                 {% set field_expr %}object['{{ field.name }}']{% endset -%}
@@ -23,7 +25,7 @@ export const {{ type_name }}Serializer = {
         };
     },
 
-    _toJsonObject(self: {{ type_name }}): any {
+    _toJsonObject({{ underscore_prefix }}self: {{ type_name }}): any {
         return {
             {% for field in type.fields -%}
                 {% set field_expr %}self.{{ field.name | to_lower_camel_case }}{% endset -%}

codegen/templates/javascript/types/struct_enum.ts.jinja

@@ -17,6 +17,7 @@ interface _{{ type_name }}Fields {
 {# export the types for enum variants without a config -#}
 {% for variant in type.variants %}
     {% if variant.schema_ref is not defined %}
+// biome-ignore lint/suspicious/noEmptyInterface: backwards compat
 interface {{ type_name }}{{ variant.name | to_upper_camel_case }}{{ type.content_field | to_upper_camel_case }} {}
     {% endif %}
 {% endfor %}
@@ -72,6 +73,7 @@ export const {{ type.name | to_upper_camel_case }}Serializer = {
     },
 
     _toJsonObject(self: {{ type.name | to_upper_camel_case }}): any {
+        // biome-ignore lint/suspicious/noImplicitAnyLet: the return type needs to be any
         let {{ content_field_name }};
         switch (self.{{ disc_field_name }}) {
         {%- for variant in type.variants %}

javascript/biome.jsonc

@@ -18,24 +18,15 @@
         "rules": {
             "recommended": true,
             "complexity": {
-                // needs codegen fix
                 "useLiteralKeys": "off"
             },
-            "correctness": {
-                // needs codegen fix
-                "noUnusedFunctionParameters": "off"
-            },
             "style": {
                 // needs codegen fix
                 "noNonNullAssertion": "off"
             },
             "suspicious": {
                 // needs codegen fix
-                "noExplicitAny": "off",
-                // needs codegen fix
-                "noEmptyInterface": "off",
-                // needs codegen fix
-                "noImplicitAnyLet": "off"
+                "noExplicitAny": "off"
             }
         }
     },

javascript/src/KitchenSink.test.ts

@@ -18,11 +18,15 @@ function getTestClient(): Svix | null {
 const client = getTestClient();
 
 // Auto-skip tests in this module if we don't have a test client to work with.
-test("e2e tests", { skip: client == null }, async (t) => {
+test("e2e tests", { skip: client === null }, async (t) => {
   await t.test("endpoint crud", async () => {
-    const appOut = await client!.application.create({ name: "App" });
+    if (client === null || client === undefined) {
+      throw new Error("unreachable");
+    }
+
+    const appOut = await client.application.create({ name: "App" });
     try {
-      await client!.eventType.create({
+      await client.eventType.create({
         name: "event.started",
         description: "Something started",
       });
@@ -31,7 +35,7 @@ test("e2e tests", { skip: client == null }, async (t) => {
       assert.deepEqual((e as ApiException<HttpErrorOut>).code, 409);
     }
     try {
-      await client!.eventType.create({
+      await client.eventType.create({
         name: "event.ended",
         description: "Something ended",
       });
@@ -40,21 +44,21 @@ test("e2e tests", { skip: client == null }, async (t) => {
       assert.deepEqual((e as ApiException<HttpErrorOut>).code, 409);
     }
 
-    const epOut = await client!.endpoint.create(appOut!.id!, {
+    const epOut = await client.endpoint.create(appOut.id, {
       url: "https://example.svix.com/",
       channels: ["ch0", "ch1"],
     });
-    assert.deepEqual(epOut!.channels!.sort(), ["ch0", "ch1"]);
-    assert.deepEqual(epOut!.filterTypes || [], []);
+    assert.deepEqual(epOut.channels?.sort(), ["ch0", "ch1"]);
+    assert.deepEqual(epOut.filterTypes || [], []);
 
-    const epPatched = await client!.endpoint.patch(appOut!.id!, epOut!.id!, {
+    const epPatched = await client.endpoint.patch(appOut.id, epOut.id, {
       filterTypes: ["event.started", "event.ended"],
     });
 
-    assert.deepEqual(epPatched!.channels!.sort(), ["ch0", "ch1"]);
-    assert.deepEqual(epPatched!.filterTypes!.sort(), ["event.ended", "event.started"]);
+    assert.deepEqual(epPatched.channels?.sort(), ["ch0", "ch1"]);
+    assert.deepEqual(epPatched.filterTypes?.sort(), ["event.ended", "event.started"]);
 
     // Should not throw an error while trying to deserialize the empty body.
-    await client!.endpoint.delete(appOut!.id!, epOut!.id!);
+    await client.endpoint.delete(appOut.id, epOut.id);
   });
 });

javascript/src/models/adobeSignConfigOut.ts

@@ -1,13 +1,15 @@
 // this file is @generated
 
+// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat
+
 export interface AdobeSignConfigOut {}
 
 export const AdobeSignConfigOutSerializer = {
-  _fromJsonObject(object: any): AdobeSignConfigOut {
+  _fromJsonObject(_object: any): AdobeSignConfigOut {
     return {};
   },
 
-  _toJsonObject(self: AdobeSignConfigOut): any {
+  _toJsonObject(_self: AdobeSignConfigOut): any {
     return {};
   },
 };

javascript/src/models/airwallexConfigOut.ts

@@ -1,13 +1,15 @@
 // this file is @generated
 
+// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat
+
 export interface AirwallexConfigOut {}
 
 export const AirwallexConfigOutSerializer = {
-  _fromJsonObject(object: any): AirwallexConfigOut {
+  _fromJsonObject(_object: any): AirwallexConfigOut {
     return {};
   },
 
-  _toJsonObject(self: AirwallexConfigOut): any {
+  _toJsonObject(_self: AirwallexConfigOut): any {
     return {};
   },
 };

javascript/src/models/checkbookConfigOut.ts

@@ -1,13 +1,15 @@
 // this file is @generated
 
+// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat
+
 export interface CheckbookConfigOut {}
 
 export const CheckbookConfigOutSerializer = {
-  _fromJsonObject(object: any): CheckbookConfigOut {
+  _fromJsonObject(_object: any): CheckbookConfigOut {
     return {};
   },
 
-  _toJsonObject(self: CheckbookConfigOut): any {
+  _toJsonObject(_self: CheckbookConfigOut): any {
     return {};
   },
 };

javascript/src/models/docusignConfigOut.ts

@@ -1,13 +1,15 @@
 // this file is @generated
 
+// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat
+
 export interface DocusignConfigOut {}
 
 export const DocusignConfigOutSerializer = {
-  _fromJsonObject(object: any): DocusignConfigOut {
+  _fromJsonObject(_object: any): DocusignConfigOut {
     return {};
   },
 
-  _toJsonObject(self: DocusignConfigOut): any {
+  _toJsonObject(_self: DocusignConfigOut): any {
     return {};
   },
 };

javascript/src/models/easypostConfigOut.ts

@@ -1,13 +1,15 @@
 // this file is @generated
 
+// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat
+
 export interface EasypostConfigOut {}
 
 export const EasypostConfigOutSerializer = {
-  _fromJsonObject(object: any): EasypostConfigOut {
+  _fromJsonObject(_object: any): EasypostConfigOut {
     return {};
   },
 
-  _toJsonObject(self: EasypostConfigOut): any {
+  _toJsonObject(_self: EasypostConfigOut): any {
     return {};
   },
 };

javascript/src/models/githubConfigOut.ts

@@ -1,13 +1,15 @@
 // this file is @generated
 
+// biome-ignore-all lint/suspicious/noEmptyInterface: backwards compat
+
 export interface GithubConfigOut {}
 
 export const GithubConfigOutSerializer = {
-  _fromJsonObject(object: any): GithubConfigOut {
+  _fromJsonObject(_object: any): GithubConfigOut {
     return {};
   },
 
-  _toJsonObject(self: GithubConfigOut): any {
+  _toJsonObject(_self: GithubConfigOut): any {
     return {};
   },
 };