fix: restrict emmet completion with emmet specific triggerCharacter (#2873)

* wip

* test

* changeset

* format

Author: jasonlyu123

.changeset/kind-carrots-pull.md

@@ -1,5 +1,5 @@
 ---
-"svelte-language-server": patch
+'svelte-language-server': patch
 ---
 
 fix: support for @nativescript-community/svelte-native

.changeset/silent-cases-sing.md

@@ -0,0 +1,5 @@
+---
+'svelte-language-server': patch
+---
+
+fix: restrict emmet completion with emmet specific triggerCharacter

packages/language-server/src/plugins/html/HTMLPlugin.ts

@@ -147,7 +147,17 @@ export class HTMLPlugin
             completionContext?.triggerCharacter &&
             !this.htmlTriggerCharacters.includes(completionContext?.triggerCharacter)
         ) {
-            return doEmmetCompleteInner() ?? null;
+            const node = html.findNodeAt(document.offsetAt(position));
+            const offset = document.offsetAt(position);
+            if (
+                !node?.tag ||
+                (offset > (node.startTagEnd ?? node.end) &&
+                    (node.endTagStart == null || offset <= node.endTagStart))
+            ) {
+                return doEmmetCompleteInner() ?? null;
+            }
+
+            return null;
         }
 
         const results = this.isInComponentTag(html, document, position)

packages/language-server/src/plugins/typescript/service.ts

@@ -794,7 +794,9 @@ async function createLanguageService(
             //override if we detect svelte-native
             if (workspacePath) {
                 try {
-                    const svelteNativePkgInfo = getPackageInfo('@nativescript-community/svelte-native', workspacePath) || getPackageInfo('svelte-native', workspacePath);
+                    const svelteNativePkgInfo =
+                        getPackageInfo('@nativescript-community/svelte-native', workspacePath) ||
+                        getPackageInfo('svelte-native', workspacePath);
                     if (svelteNativePkgInfo.path) {
                         // For backwards compatibility
                         parsedConfig.raw.svelteOptions = parsedConfig.raw.svelteOptions || {};

packages/language-server/test/plugins/html/HTMLPlugin.test.ts

@@ -190,6 +190,16 @@ describe('HTML Plugin', () => {
         assert.strictEqual(completions?.items[0]?.label, 'div>');
     });
 
+    it('skip emmet completions right after start tag close', async () => {
+        const { plugin, document } = setup('Test.a>');
+
+        const completions = await plugin.getCompletions(document, Position.create(0, 5), {
+            triggerCharacter: '>',
+            triggerKind: CompletionTriggerKind.TriggerCharacter
+        });
+        assert.strictEqual(completions, null);
+    });
+
     it('does not provide rename for element being uppercase', async () => {
         const { plugin, document } = setup('<Div></Div>');