Merge pull request #33 from Rich-Harris/prevent-duplicate-names

prevent duplicate parameter names

Author: Rich-Harris

devalue.js

@@ -243,7 +243,7 @@ function get_name(num) {
 		num = ~~(num / chars.length) - 1;
 	} while (num >= 0);
 
-	return reserved.test(name) ? `${name}_` : name;
+	return reserved.test(name) ? `${name}0` : name;
 }
 
 /** @param {any} thing */

devalue.test.js

@@ -45,6 +45,22 @@ function throws(name, fn) {
 	}
 }
 
+/**
+ *
+ * @param {string} name
+ * @param {(...args: any[]) => void} fn
+ */
+function allows(name, fn) {
+	try {
+		fn();
+		console.log(`✅ ${name}`);
+		passed += 1;
+	} catch (e) {
+		console.log(`❌ ${name} (${e.message})`);
+		failed += 1;
+	}
+}
+
 describe('basics', (t) => {
 	t('number', 42, '42');
 	t('negative number', -42, '-42');
@@ -173,6 +189,14 @@ describe('misc', (t) => {
 	throws('throws for symbolic keys', () => {
 		devalue({ [Symbol()]: null });
 	});
+
+	allows('does not create duplicate parameter names', () => {
+		const foo = new Array(20000).fill(0).map((_, i) => i);
+		const bar = foo.map((_, i) => ({ [i]: foo[i] }));
+		const serialized = devalue([foo, ...bar]);
+
+		eval(serialized);
+	});
 });
 
 console.log(`\n---\n${passed} passed, ${failed} failed\n`);