Merge pull request #80 from danielroe/fix/proto

fix: do not iterate over prototype properties of reducers

Author: Rich-Harris

src/stringify.js

@@ -31,8 +31,10 @@ export function stringify(value, reducers) {
 
 	/** @type {Array<{ key: string, fn: (value: any) => any }>} */
 	const custom = [];
-	for (const key in reducers) {
-		custom.push({ key, fn: reducers[key] });
+	if (reducers) {
+		for (const key of Object.getOwnPropertyNames(reducers)) {
+			custom.push({ key, fn: reducers[key] });
+		}
 	}
 
 	/** @type {string[]} */

test/test.js

@@ -167,7 +167,7 @@ const fixtures = {
 			json: '[["Uint8Array","AQID"]]'
 		},
 		{
-			name: "ArrayBuffer",
+			name: 'ArrayBuffer',
 			value: new Uint8Array([1, 2, 3]).buffer,
 			js: 'new Uint8Array([1,2,3]).buffer',
 			json: '[["ArrayBuffer","AQID"]]'
@@ -429,9 +429,10 @@ const fixtures = {
 					return `new Custom(${uneval(value.value)})`;
 				}
 			},
-			reducers: {
+			// test for https://github.com/Rich-Harris/devalue/pull/80
+			reducers: Object.assign(Object.create({ polluted: true }), {
 				Custom: (x) => x instanceof Custom && x.value
-			},
+			}),
 			revivers: {
 				Custom: (x) => new Custom(x)
 			},