Skip to content

Commit 8e985a7

Browse files
committed
refactor: move USB device observation out of the init method
1 parent 745467c commit 8e985a7

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

app/src/main/java/org/kabiri/android/usbterminal/MainActivity.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ import androidx.activity.viewModels
1616
import androidx.appcompat.app.AppCompatActivity
1717
import androidx.core.view.ViewCompat
1818
import androidx.core.view.WindowInsetsCompat
19+
import androidx.lifecycle.Lifecycle
1920
import androidx.lifecycle.lifecycleScope
21+
import androidx.lifecycle.repeatOnLifecycle
2022
import dagger.hilt.android.AndroidEntryPoint
2123
import kotlinx.coroutines.launch
2224
import org.kabiri.android.usbterminal.util.scrollToLastLine
@@ -36,6 +38,7 @@ class MainActivity : AppCompatActivity() {
3638

3739
override fun onCreate(savedInstanceState: Bundle?) {
3840
super.onCreate(savedInstanceState)
41+
viewModel.startObservingUsbDevice()
3942
setContentView(R.layout.activity_main)
4043

4144
// avoid system navbar or soft keyboard overlapping the content.

app/src/main/java/org/kabiri/android/usbterminal/viewmodel/MainActivityViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ internal class MainActivityViewModel
4949

5050
val output2 = SnapshotStateList<OutputText>()
5151

52-
init {
52+
internal fun startObservingUsbDevice() {
5353
// Subscribe to USB device changes.
5454
viewModelScope.launch {
5555
usbUseCase.usbDevice.collect { device ->

0 commit comments

Comments
 (0)