From d804f998cead6472abb8704be7f0f76848f74d6b Mon Sep 17 00:00:00 2001 From: RJ Nowling <130711295+rnowling-memphis@users.noreply.github.com> Date: Sat, 27 May 2023 23:03:06 -0500 Subject: [PATCH 1/2] Add Pylint GitHub action In addition to checking for "code quality" (e.g., coding conventions), Pylint can find logical (e.g., calling methods with an incorrect number of arguments) errors. This can help us ensure that the code in the master branch remains in a working state. --- .github/workflows/pylint.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/pylint.yml diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml new file mode 100644 index 0000000..383e65c --- /dev/null +++ b/.github/workflows/pylint.yml @@ -0,0 +1,23 @@ +name: Pylint + +on: [push] + +jobs: + build: + runs-on: ubuntu-latest + strategy: + matrix: + python-version: ["3.8", "3.9", "3.10"] + steps: + - uses: actions/checkout@v3 + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v3 + with: + python-version: ${{ matrix.python-version }} + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install pylint + - name: Analysing the code with pylint + run: | + pylint $(git ls-files '*.py') From b7858bd0b55f8630df0ef48d9e6e44bc3168e757 Mon Sep 17 00:00:00 2001 From: RJ Nowling <130711295+rnowling-memphis@users.noreply.github.com> Date: Sat, 27 May 2023 23:16:19 -0500 Subject: [PATCH 2/2] Install library Install the Memphis.py library so that we can grab the dependencies to avoid import errors --- .github/workflows/pylint.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml index 383e65c..7bb3e66 100644 --- a/.github/workflows/pylint.yml +++ b/.github/workflows/pylint.yml @@ -16,8 +16,9 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install dependencies run: | - python -m pip install --upgrade pip + python -m pip install --upgrade pip wheel pip install pylint + python setup.py install - name: Analysing the code with pylint run: | pylint $(git ls-files '*.py')