chore: reproduce invalid node type error

Author: avallete

src/select-query-parser/result.ts

@@ -197,13 +197,13 @@ export type ProcessNode<
   RelationName extends string,
   Relationships extends GenericRelationship[],
   NodeType extends Ast.Node
-> = NodeType['type'] extends Ast.StarNode['type'] // If the selection is *
+> = NodeType extends Ast.StarNode // If the selection is *
   ? Row
-  : NodeType['type'] extends Ast.SpreadNode['type'] // If the selection is a ...spread
-  ? ProcessSpreadNode<Schema, Row, RelationName, Relationships, Extract<NodeType, Ast.SpreadNode>>
-  : NodeType['type'] extends Ast.FieldNode['type']
-  ? ProcessFieldNode<Schema, Row, RelationName, Relationships, Extract<NodeType, Ast.FieldNode>>
-  : SelectQueryError<'Unsupported node type.'>
+  : NodeType extends Ast.SpreadNode // If the selection is a ...spread
+  ? ProcessSpreadNode<Schema, Row, RelationName, Relationships, NodeType>
+  : NodeType extends Ast.FieldNode
+  ? ProcessFieldNode<Schema, Row, RelationName, Relationships, NodeType>
+  : SelectQueryError<'Unsupported node type.' & { nodeType: NodeType }>
 
 /**
  * Processes a FieldNode and returns the resulting TypeScript type.
@@ -369,7 +369,10 @@ type ProcessSpreadNode<
 /**
  * Helper type to process the result of a spread node.
  */
-type ProcessSpreadNodeResult<Result> = Result extends Record<string, SelectQueryError<string>>
+type ProcessSpreadNodeResult<Result> = Result extends Record<
+  string,
+  SelectQueryError<string> | null
+>
   ? Result
   : ExtractFirstProperty<Result> extends infer SpreadedObject
   ? ContainsNull<SpreadedObject> extends true

test/select-query-parser/result.test-d.ts

@@ -86,3 +86,35 @@ type SelectQueryFromTableResult<
   }
   expectType<TypeEqual<typeof result, typeof expected>>(true)
 }
+
+{
+  let result: SelectQueryFromTableResult<
+    'users',
+    `msgs:messages(id, ...channels(id, ...channel_details(id, missing_col)))`
+  >
+  let expected: {
+    msgs: {
+      id: number
+      channel_details: SelectQueryError<"column 'missing_col' does not exist on 'channel_details'."> | null
+    }[]
+  }
+  expectType<TypeEqual<typeof result, typeof expected>>(true)
+}
+
+{
+  let result1: SelectQueryFromTableResult<
+    'users',
+    `msgs:messages(...channels(slug, channel_details!inner(id, details, channel:channels(*))))`
+  >
+  let result2: SelectQueryFromTableResult<
+    'users',
+    `msgs:messages(...channels(slug, channel_details!inner(channel:channels(*), id, details)))`
+  >
+  let result3: SelectQueryFromTableResult<
+    'users',
+    `msgs:messages(...channels!inner(slug, channel_details!inner(id, details, channel:channels(*))))`
+  >
+  // All variations should not change the result
+  expectType<typeof result1>(result2!)
+  expectType<typeof result2>(result3!)
+}