fix: mark optional function parameters for typescript gen

Co-authored-by: Han Qiao <qiao@supabase.io>

Author: davepar

src/lib/sql/functions.sql

@@ -15,7 +15,10 @@ with functions as (
       array_fill(''::text, array[cardinality(coalesce(p.proallargtypes, p.proargtypes))])
     ) as arg_names,
     -- proallargtypes is null when all arg modes are IN
-    coalesce(p.proallargtypes, p.proargtypes) as arg_types
+    coalesce(p.proallargtypes, p.proargtypes) as arg_types,
+    array_cat(
+      array_fill(false, array[pronargs - pronargdefaults]),
+      array_fill(true, array[pronargdefaults])) as arg_has_defaults
   from
     pg_proc as p
   where
@@ -69,14 +72,20 @@ from
   left join (
     select
       oid,
-      jsonb_agg(jsonb_build_object('mode', t2.mode, 'name', name, 'type_id', type_id)) as args
+      jsonb_agg(jsonb_build_object(
+        'mode', t2.mode,
+        'name', name,
+        'type_id', type_id,
+        'has_default', has_default
+      )) as args
     from
       (
         select
           oid,
           unnest(arg_modes) as mode,
           unnest(arg_names) as name,
-          unnest(arg_types)::int8 as type_id
+          unnest(arg_types)::int8 as type_id,
+          unnest(arg_has_defaults) as has_default
         from
           functions
       ) as t1,

src/lib/types.ts

@@ -102,6 +102,7 @@ const postgresFunctionSchema = Type.Object({
       ]),
       name: Type.String(),
       type_id: Type.Number(),
+      has_default: Type.Boolean(),
     })
   ),
   argument_types: Type.String(),

src/server/templates/typescript.ts

@@ -230,25 +230,31 @@ export interface Database {
                       return 'Record<PropertyKey, never>'
                     }
 
-                    const argsNameAndType = inArgs.map(({ name, type_id }) => {
+                    const argsNameAndType = inArgs.map(({ name, type_id, has_default }) => {
                       let type = arrayTypes.find(({ id }) => id === type_id)
                       if (type) {
                         // If it's an array type, the name looks like `_int8`.
                         const elementTypeName = type.name.substring(1)
                         return {
                           name,
                           type: `(${pgTypeToTsType(elementTypeName, types, schemas)})[]`,
+                          has_default,
                         }
                       }
                       type = types.find(({ id }) => id === type_id)
                       if (type) {
-                        return { name, type: pgTypeToTsType(type.name, types, schemas) }
+                        return {
+                          name,
+                          type: pgTypeToTsType(type.name, types, schemas),
+                          has_default,
+                        }
                       }
-                      return { name, type: 'unknown' }
+                      return { name, type: 'unknown', has_default }
                     })
 
                     return `{ ${argsNameAndType.map(
-                      ({ name, type }) => `${JSON.stringify(name)}: ${type}`
+                      ({ name, type, has_default }) =>
+                        `${JSON.stringify(name)}${has_default ? '?' : ''}: ${type}`
                     )} }`
                   })()}
                   Returns: ${(() => {

test/lib/functions.ts

@@ -8,11 +8,13 @@ test('list', async () => {
     {
       "args": [
         {
+          "has_default": false,
           "mode": "in",
           "name": "",
           "type_id": 23,
         },
         {
+          "has_default": false,
           "mode": "in",
           "name": "",
           "type_id": 23,
@@ -98,11 +100,13 @@ test('retrieve, create, update, delete', async () => {
       "data": {
         "args": [
           {
+            "has_default": false,
             "mode": "in",
             "name": "a",
             "type_id": 21,
           },
           {
+            "has_default": false,
             "mode": "in",
             "name": "b",
             "type_id": 21,
@@ -143,11 +147,13 @@ test('retrieve, create, update, delete', async () => {
       "data": {
         "args": [
           {
+            "has_default": false,
             "mode": "in",
             "name": "a",
             "type_id": 21,
           },
           {
+            "has_default": false,
             "mode": "in",
             "name": "b",
             "type_id": 21,
@@ -192,11 +198,13 @@ test('retrieve, create, update, delete', async () => {
       "data": {
         "args": [
           {
+            "has_default": false,
             "mode": "in",
             "name": "a",
             "type_id": 21,
           },
           {
+            "has_default": false,
             "mode": "in",
             "name": "b",
             "type_id": 21,
@@ -237,11 +245,13 @@ test('retrieve, create, update, delete', async () => {
       "data": {
         "args": [
           {
+            "has_default": false,
             "mode": "in",
             "name": "a",
             "type_id": 21,
           },
           {
+            "has_default": false,
             "mode": "in",
             "name": "b",
             "type_id": 21,