chore(server): validate batch column create

Author: soedirgo

src/server/routes/columns.ts

@@ -1,5 +1,11 @@
+import { Type } from '@sinclair/typebox'
 import { FastifyInstance } from 'fastify'
 import { PostgresMeta } from '../../lib'
+import {
+  PostgresColumnCreate,
+  postgresColumnSchema,
+  postgresColumnCreateSchema,
+} from '../../lib/types'
 import { DEFAULT_POOL_CONFIG } from '../constants'
 import { extractRequestForLogging } from '../utils'
 
@@ -33,7 +39,6 @@ export default async (fastify: FastifyInstance) => {
     return data
   })
 
-  // deprecated: use GET /batch instead
   fastify.get<{
     Headers: { pg: string }
     Params: {
@@ -55,32 +60,51 @@ export default async (fastify: FastifyInstance) => {
     return data
   })
 
-  // deprecated: use POST /batch instead
-  // TODO (darora): specifying a schema on the routes would both allow for validation, and enable us to mark methods as deprecated
   fastify.post<{
     Headers: { pg: string }
-    Body: any
-  }>('/', async (request, reply) => {
-    const connectionString = request.headers.pg
-    const pgMeta = new PostgresMeta({ ...DEFAULT_POOL_CONFIG, connectionString })
-    if (!Array.isArray(request.body)) {
-      request.body = [request.body]
-    }
+    Body: PostgresColumnCreate | PostgresColumnCreate[]
+  }>(
+    '/',
+    {
+      schema: {
+        headers: Type.Object({
+          pg: Type.String(),
+        }),
+        body: Type.Union([postgresColumnCreateSchema, Type.Array(postgresColumnCreateSchema)]),
+        response: {
+          200: Type.Union([postgresColumnSchema, Type.Array(postgresColumnSchema)]),
+          400: Type.Object({
+            error: Type.String(),
+          }),
+          404: Type.Object({
+            error: Type.String(),
+          }),
+        },
+      },
+    },
+    async (request, reply) => {
+      const connectionString = request.headers.pg
 
-    const { data, error } = await pgMeta.columns.batchCreate(request.body)
-    await pgMeta.end()
-    if (error) {
-      request.log.error({ error, request: extractRequestForLogging(request) })
-      reply.code(400)
-      if (error.message.startsWith('Cannot find')) reply.code(404)
-      return { error: error.message }
-    }
+      const pgMeta = new PostgresMeta({ ...DEFAULT_POOL_CONFIG, connectionString })
+      if (!Array.isArray(request.body)) {
+        request.body = [request.body]
+      }
+
+      const { data, error } = await pgMeta.columns.batchCreate(request.body)
+      await pgMeta.end()
+      if (error) {
+        request.log.error({ error, request: extractRequestForLogging(request) })
+        reply.code(400)
+        if (error.message.startsWith('Cannot find')) reply.code(404)
+        return { error: error.message }
+      }
 
-    if (Array.isArray(request.body)) {
-      return data
+      if (Array.isArray(request.body)) {
+        return data
+      }
+      return data[0]
     }
-    return data[0]
-  })
+  )
 
   fastify.patch<{
     Headers: { pg: string }