fix: /columns default_value for text

In the SQL for default_value, the string literal should be quoted.

Author: soedirgo

src/api/columns.ts

@@ -1,5 +1,5 @@
 import { Router } from 'express'
-import format from 'pg-format'
+import format, { literal } from 'pg-format'
 import SQL from 'sql-template-strings'
 import { RunQuery } from '../lib/connectionPool'
 import sql = require('../lib/sql')
@@ -119,7 +119,14 @@ const addColumnSqlize = ({
   is_unique?: boolean
   comment?: string
 }) => {
-  const defaultValueSql = default_value === undefined ? '' : `DEFAULT ${default_value}`
+  let defaultValueSql: string
+  if (default_value === undefined) {
+    defaultValueSql = ''
+  } else if (typeof default_value === 'string') {
+    defaultValueSql = `DEFAULT ${literal(default_value)}`
+  } else {
+    defaultValueSql = `DEFAULT ${default_value}`
+  }
   const isIdentitySql = is_identity ? 'GENERATED BY DEFAULT AS IDENTITY' : ''
   const isNullableSql = is_nullable ? 'NULL' : 'NOT NULL'
   const isPrimaryKeySql = is_primary_key ? 'PRIMARY KEY' : ''

test/integration/index.spec.js

@@ -308,6 +308,20 @@ describe('/tables', async () => {
     await axios.delete(`${URL}/columns/${newTable.id}.1`)
     await axios.delete(`${URL}/tables/${newTable.id}`)
   })
+  it('/columns default_value for type text', async () => {
+    const { data: newTable } = await axios.post(`${URL}/tables`, { name: 'a' })
+    const { data: newColumn } = await axios.post(`${URL}/columns`, {
+      table_id: newTable.id,
+      name: 'a',
+      type: 'text',
+      default_value: 'a',
+    })
+
+    assert.equal(newColumn.default_value, `'a'::text`)
+
+    await axios.delete(`${URL}/columns/${newTable.id}.1`)
+    await axios.delete(`${URL}/tables/${newTable.id}`)
+  })
   it('PATCH /columns', async () => {
     const { data: newTable } = await axios.post(`${URL}/tables`, { name: 'foo bar' })
     await axios.post(`${URL}/columns`, {