refactor: add some small changes

Author: ftonato

src/api/columns.ts

@@ -128,14 +128,13 @@ const addColumnSqlize = ({
   is_unique?: boolean
   comment?: string
 }) => {
-  let defaultValueSql: string
+  let defaultValueSql: string = `DEFAULT ${literal(default_value)}`
   if (default_value === undefined) {
     defaultValueSql = ''
   } else if (default_value_format === 'expression') {
     defaultValueSql = `DEFAULT ${default_value}`
-  } else {
-    defaultValueSql = `DEFAULT ${literal(default_value)}`
   }
+
   const isIdentitySql = is_identity ? `GENERATED ${identity_generation} AS IDENTITY` : ''
   const isNullableSql = is_nullable ? 'NULL' : 'NOT NULL'
   const isPrimaryKeySql = is_primary_key ? 'PRIMARY KEY' : ''
@@ -215,7 +214,7 @@ const alterColumnSqlize = (
   } else if (default_value === undefined) {
     defaultValueSql = ''
   } else {
-    let defaultValue =
+    const defaultValue =
       default_value_format === 'expression' ? default_value : literal(default_value)
     defaultValueSql = format(
       `ALTER TABLE %I.%I ALTER COLUMN %I SET DEFAULT ${defaultValue};`,

src/api/policies.ts

@@ -1,6 +1,6 @@
 import { Router } from 'express'
 import format from 'pg-format'
-import { coalesceRowsToArray, toTransaction } from '../lib/helpers'
+import { toTransaction } from '../lib/helpers'
 import { RunQuery } from '../lib/connectionPool'
 import { DEFAULT_SYSTEM_SCHEMAS } from '../lib/constants'
 import { Tables } from '../lib/interfaces'
@@ -61,7 +61,7 @@ router.patch('/:id', async (req, res) => {
     const payload: Tables.Policy = { ...req.body }
     const previousPolicy: Tables.Policy = await getPolicyById(pcConnection, id)
     const nameChange = !!payload.name && payload.name != previousPolicy.name
-    let updates = { ...payload }
+    const updates = { ...payload }
     if (!updates.name) updates.name = previousPolicy.name
     if (!updates.schema) updates.schema = previousPolicy.schema
     if (!updates.table) updates.table = previousPolicy.table
@@ -115,7 +115,7 @@ const getAllSql = (sqlTemplates) => {
 }
 const getPolicyById = async (connection: string, id: number) => {
   const { policies } = sqlTemplates
-  let sql = `
+  const sql = `
     with policies as (${policies}) 
     select * from policies
     where policies.id = ${id}
@@ -191,10 +191,10 @@ const alterSql = ({
   check?: string
   roles?: string[]
 }) => {
-  let alter = format(`ALTER POLICY %I ON %I.%I`, name, schema, table)
-  let newDefinition = definition !== undefined ? `${alter} USING (${definition});` : ''
-  let newCheck = check !== undefined ? `${alter} WITH CHECK (${check});` : ''
-  let newRoles = roles !== undefined ? `${alter} TO (${roles.join(',')});` : ''
+  const alter = format(`ALTER POLICY %I ON %I.%I`, name, schema, table)
+  const newDefinition = definition !== undefined ? `${alter} USING (${definition});` : ''
+  const newCheck = check !== undefined ? `${alter} WITH CHECK (${check});` : ''
+  const newRoles = roles !== undefined ? `${alter} TO (${roles.join(',')});` : ''
 
   return `
     ${newDefinition}

src/api/publications.ts

@@ -89,16 +89,14 @@ const createPublicationSqlize = ({
   publish_truncate?: boolean
   tables?: string[]
 }) => {
-  let tableClause: string
+  let tableClause: string = `FOR TABLE ${tables.map(ident).join(',')}`
   if (tables === undefined) {
     tableClause = 'FOR ALL TABLES'
   } else if (tables.length === 0) {
     tableClause = ''
-  } else {
-    tableClause = `FOR TABLE ${tables.map(ident).join(',')}`
   }
 
-  let publishOps = []
+  const publishOps = []
   if (publish_insert) publishOps.push('insert')
   if (publish_update) publishOps.push('update')
   if (publish_delete) publishOps.push('delete')

src/api/tables.ts

@@ -62,7 +62,7 @@ router.post('/', async (req, res) => {
     // Return fresh details
     const getTable = selectSingleByName(sqlTemplates, schema, name)
     const { data: newTableResults } = await RunQuery(pcConnection, getTable)
-    let newTable: Tables.Table = newTableResults[0]
+    const newTable: Tables.Table = newTableResults[0]
     return res.status(200).json(newTable)
   } catch (error) {
     logger.error({ error, req: req.body })
@@ -82,7 +82,7 @@ router.patch('/:id', async (req, res) => {
     // Get table
     const getTableSql = selectSingleSql(sqlTemplates, id)
     const { data: getTableResults } = await RunQuery(pcConnection, getTableSql)
-    let previousTable: Tables.Table = getTableResults[0]
+    const previousTable: Tables.Table = getTableResults[0]
 
     // Update fields and name
     const nameSql =
@@ -243,16 +243,18 @@ const createTableSqlize = ({
   comment?: string
 }) => {
   const tableSql = format('CREATE TABLE IF NOT EXISTS %I.%I ();', schema, name)
-  let replicaSql: string
+  let replicaSql: string = `ALTER TABLE ${ident(schema)}.${ident(
+    name
+  )} REPLICA IDENTITY ${replica_identity};`
+
   if (replica_identity === undefined) {
     replicaSql = ''
   } else if (replica_identity === 'INDEX') {
     replicaSql = `ALTER TABLE ${ident(schema)}.${ident(
       name
     )} REPLICA IDENTITY USING INDEX ${replica_identity_index};`
-  } else {
-    replicaSql = `ALTER TABLE ${ident(schema)}.${ident(name)} REPLICA IDENTITY ${replica_identity};`
   }
+
   const commentSql =
     comment === undefined ? '' : format('COMMENT ON TABLE %I.%I IS %L;', schema, name, comment)
   return `

src/lib/helpers.ts

@@ -21,6 +21,6 @@ export const toTransaction = (statements: string[]) => {
     if (sql.length > 0 && x.slice(-1) !== ';') sql += ';'
     return sql
   })
-  let allStatements = cleansed.join('')
+  const allStatements = cleansed.join('')
   return `BEGIN; ${allStatements} COMMIT;`
 }

src/server.ts

@@ -18,7 +18,7 @@ app.get('/', (_req, res) =>
 )
 app.get('/health', (_req, res) => res.status(200).json({ date: new Date() }))
 
-let Server = {
+const Server = {
   start(port: number) {
     this.server = app.listen(port, () => {
       logger.info(`App started on port ${port}`)