fix: escape underscore in sql like syntax (#3586)

Author: sweatybridge

internal/db/diff/diff_test.go

@@ -268,7 +268,7 @@ func TestDiffDatabase(t *testing.T) {
 		// Check error
 		assert.Empty(t, diff)
 		assert.ErrorContains(t, err, `ERROR: schema "public" already exists (SQLSTATE 42P06)
-At statement 0:
+At statement: 0
 create schema public`)
 		assert.Empty(t, apitest.ListUnmatchedRequests())
 	})

internal/db/push/push_test.go

@@ -105,7 +105,7 @@ func TestMigrationPush(t *testing.T) {
 		err := Run(context.Background(), false, false, false, false, dbConfig, fsys, conn.Intercept)
 		// Check error
 		assert.ErrorContains(t, err, `ERROR: null value in column "version" of relation "schema_migrations" (SQLSTATE 23502)`)
-		assert.ErrorContains(t, err, "At statement 0:\n"+migration.INSERT_MIGRATION_VERSION)
+		assert.ErrorContains(t, err, "At statement: 0\n"+migration.INSERT_MIGRATION_VERSION)
 	})
 }
 

pkg/migration/file.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"crypto/sha256"
 	"encoding/hex"
+	"fmt"
 	"io"
 	"io/fs"
 	"path/filepath"
@@ -88,11 +89,16 @@ func (m *MigrationFile) ExecBatch(ctx context.Context, conn *pgx.Conn) error {
 		if i < len(m.Statements) {
 			stat = m.Statements[i]
 		}
+		var msg []string
 		var pgErr *pgconn.PgError
 		if errors.As(err, &pgErr) {
 			stat = markError(stat, int(pgErr.Position))
+			if len(pgErr.Detail) > 0 {
+				msg = append(msg, pgErr.Detail)
+			}
 		}
-		return errors.Errorf("%w\nAt statement %d:\n%s", err, i, stat)
+		msg = append(msg, fmt.Sprintf("At statement: %d", i), stat)
+		return errors.Errorf("%w\n%s", err, strings.Join(msg, "\n"))
 	}
 	return nil
 }

pkg/migration/file_test.go

@@ -75,6 +75,6 @@ func TestMigrationFile(t *testing.T) {
 		err := migration.ExecBatch(context.Background(), conn.MockClient(t))
 		// Check error
 		assert.ErrorContains(t, err, "ERROR: schema \"public\" already exists (SQLSTATE 42P06)")
-		assert.ErrorContains(t, err, "At statement 0:\ncreate schema public")
+		assert.ErrorContains(t, err, "At statement: 0\ncreate schema public")
 	})
 }

pkg/migration/queries/drop.sql

@@ -103,7 +103,7 @@ begin
     select *
     from pg_publication p
     where
-      p.pubname not like 'supabase_realtime%' and p.pubname not like 'realtime_messages%'
+      not p.pubname like any(array['supabase\_realtime%', 'realtime\_messages%'])
   loop
     execute format('drop publication if exists %I', rec.pubname);
   end loop;