Skip to content

refactor: move workspace features to own mod #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juleswritescode merged 2 commits into from
Mar 30, 2025
Merged

refactor: move workspace features to own mod #276

juleswritescode merged 2 commits into from
Mar 30, 2025

Conversation

@juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Mar 30, 2025 •
edited
Loading

also as discussed in this pr 👍🏻

I also moved the CompletionsResult which implements serialization/deserialization from the pgt_completions crate into the workspace.

@juleswritescode juleswritescode enabled auto-merge (squash) March 30, 2025 12:31
@juleswritescode juleswritescode enabled auto-merge (squash) March 30, 2025 12:31
psteinroe
psteinroe approved these changes Mar 30, 2025
View reviewed changes
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh much better! 🫶🏼

@juleswritescode juleswritescode merged commit 506c826 into main Mar 30, 2025
7 checks passed
@juleswritescode juleswritescode deleted the refactor/workspace-features branch October 28, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psteinroe psteinroe psteinroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juleswritescode @psteinroe