progress

Author: psteinroe

agentic/port_squawk_rules.md

@@ -18,13 +18,28 @@ pub struct RuleContext<'a, R: Rule> {
     file_context: &'a AnalysedFileContext,
 }
 
+
 pub struct AnalysedFileContext<'a> {
-    // all other statements in this file
-    pub all_stmts: &'a Vec<pgt_query::NodeEnum>,
-    // total count of statements in this file
-    pub stmt_count: usize,
+    // all statements in this file
+    pub stmts: &'a Vec<pgt_query::NodeEnum>,
+
+    pos: usize,
+}
+
+impl<'a> AnalysedFileContext<'a> {
+    pub fn new(stmts: &'a Vec<pgt_query::NodeEnum>) -> Self {
+        Self { stmts, pos: 0 }
+    }
+
     // all statements before the currently analysed one
-    pub previous_stmts: Vec<&'a pgt_query::NodeEnum>,
+    pub fn previous_stmts(&self) -> &[pgt_query::NodeEnum] {
+        &self.stmts[0..self.pos]
+    }
+
+    // total count of statements in this file
+    pub fn stmt_count(&self) -> usize {
+        self.stmts.len()
+    }
 }
 ```
 

crates/pgt_analyse/src/analysed_file_context.rs

@@ -1,19 +1,23 @@
 pub struct AnalysedFileContext<'a> {
-    pub all_stmts: &'a Vec<pgt_query::NodeEnum>,
-    pub stmt_count: usize,
-    pub previous_stmts: Vec<&'a pgt_query::NodeEnum>,
+    pub stmts: &'a Vec<pgt_query::NodeEnum>,
+
+    pos: usize,
 }
 
 impl<'a> AnalysedFileContext<'a> {
     pub fn new(stmts: &'a Vec<pgt_query::NodeEnum>) -> Self {
-        Self {
-            all_stmts: stmts,
-            stmt_count: stmts.len(),
-            previous_stmts: Vec::new(),
-        }
+        Self { stmts, pos: 0 }
+    }
+
+    pub fn previous_stmts(&self) -> &[pgt_query::NodeEnum] {
+        &self.stmts[0..self.pos]
+    }
+
+    pub fn stmt_count(&self) -> usize {
+        self.stmts.len()
     }
 
-    pub fn update_from(&mut self, stmt_root: &'a pgt_query::NodeEnum) {
-        self.previous_stmts.push(stmt_root);
+    pub fn next(&mut self) {
+        self.pos += 1;
     }
 }

crates/pgt_analyser/src/lib.rs

@@ -84,7 +84,7 @@ impl<'a> Analyser<'a> {
 
             diagnostics.extend(stmt_diagnostics);
 
-            file_context.update_from(&roots[i]);
+            file_context.next();
         }
 
         diagnostics

crates/pgt_analyser/src/lint/safety/ban_concurrent_index_creation_in_transaction.rs

@@ -37,7 +37,7 @@ impl Rule for BanConcurrentIndexCreationInTransaction {
         //
         // since our analyser assumes we're always in a transaction context, we always flag concurrent indexes
         if let pgt_query::NodeEnum::IndexStmt(stmt) = ctx.stmt() {
-            if stmt.concurrent && ctx.file_context().stmt_count > 1 {
+            if stmt.concurrent && ctx.file_context().stmt_count() > 1 {
                 diagnostics.push(RuleDiagnostic::new(
                     rule_category!(),
                     None,

crates/pgt_analyser/src/lint/safety/disallow_unique_constraint.rs

@@ -50,7 +50,7 @@ impl Rule for DisallowUniqueConstraint {
 
             // Look for tables created in previous statements of this file
             let table_created_in_transaction = if let Some(table_name) = table_name {
-                ctx.file_context().previous_stmts.iter().any(|prev_stmt| {
+                ctx.file_context().previous_stmts().iter().any(|prev_stmt| {
                     if let pgt_query::NodeEnum::CreateStmt(create) = prev_stmt {
                         create
                             .relation

crates/pgt_analyser/src/lint/safety/require_concurrent_index_creation.rs

@@ -79,7 +79,7 @@ fn is_table_created_in_file(
     table_name: &str,
 ) -> bool {
     // Check all statements in the file to see if this table was created
-    for stmt in file_context.all_stmts {
+    for stmt in file_context.stmts {
         if let pgt_query::NodeEnum::CreateStmt(create_stmt) = stmt {
             if let Some(relation) = &create_stmt.relation {
                 if relation.relname == table_name {

crates/pgt_analyser/src/lint/safety/transaction_nesting.rs

@@ -86,7 +86,7 @@ impl Rule for TransactionNesting {
 }
 
 fn has_transaction_start_before(file_context: &AnalysedFileContext) -> bool {
-    for stmt in &file_context.previous_stmts {
+    for stmt in file_context.previous_stmts() {
         if let pgt_query::NodeEnum::TransactionStmt(tx_stmt) = stmt {
             match tx_stmt.kind() {
                 pgt_query::protobuf::TransactionStmtKind::TransStmtBegin