chore: merge main

Author: psteinroe

.cargo/config.toml

@@ -20,7 +20,6 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  RUSTFLAGS: -A dead_code
   RUST_LOG: info
   RUST_BACKTRACE: 1
   RUSTUP_WINDOWS_PATH_ADD_BIN: 1

.github/workflows/pull_request.yml

@@ -7,9 +7,6 @@ permissions:
   contents: write
 
 env:
-  # Ultimately, we shouldn't ignore warnings.
-  # We need to pass it as an ENV because inlining doesn't work on Windows.
-  RUSTFLAGS: -A dead_code
   # Need these guys for cross-compilation
   CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
   CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_LINKER: aarch64-linux-gnu-gcc

.github/workflows/release.yml

@@ -0,0 +1,3 @@
+{
+  "postgrestools.bin": "./target/debug/postgrestools"
+}

.vscode/settings.json

@@ -39,6 +39,7 @@ serde                    = "1.0.195"
 serde_json               = "1.0.114"
 similar                  = "2.6.0"
 smallvec                 = { version = "1.13.2", features = ["union", "const_new", "serde"] }
+strum                    = { version = "0.27.1", features = ["derive"] }
 # this will use tokio if available, otherwise async-std
 sqlx               = { version = "0.8.2", features = ["runtime-tokio", "runtime-async-std", "postgres", "json"] }
 syn                = "1.0.109"
@@ -57,7 +58,6 @@ pgt_analyse                = { path = "./crates/pgt_analyse", version = "0.0.0"
 pgt_analyser               = { path = "./crates/pgt_analyser", version = "0.0.0" }
 pgt_base_db                = { path = "./crates/pgt_base_db", version = "0.0.0" }
 pgt_cli                    = { path = "./crates/pgt_cli", version = "0.0.0" }
-pgt_commands               = { path = "./crates/pgt_commands", version = "0.0.0" }
 pgt_completions            = { path = "./crates/pgt_completions", version = "0.0.0" }
 pgt_configuration          = { path = "./crates/pgt_configuration", version = "0.0.0" }
 pgt_console                = { path = "./crates/pgt_console", version = "0.0.0" }

Cargo.lock

@@ -260,10 +260,6 @@ impl RuleDiagnostic {
         self.footer(LogCategory::Warn, msg)
     }
 
-    pub(crate) fn span(&self) -> Option<TextRange> {
-        self.span
-    }
-
     pub fn advices(&self) -> &RuleAdvice {
         &self.rule_advice
     }

Cargo.toml

@@ -61,10 +61,6 @@ impl CommandRunner for CheckCommandPayload {
         self.stdin_file_path.as_deref()
     }
 
-    fn should_write(&self) -> bool {
-        false
-    }
-
     fn get_execution(
         &self,
         cli_options: &CliOptions,

crates/pgt_analyse/src/rule.rs

@@ -5,7 +5,7 @@ use crate::{
 use pgt_console::{ConsoleExt, markup};
 use pgt_lsp::ServerFactory;
 use pgt_workspace::{TransportError, WorkspaceError, workspace::WorkspaceClient};
-use std::{env, fs, path::PathBuf};
+use std::{env, path::PathBuf};
 use tokio::io;
 use tokio::runtime::Runtime;
 use tracing::subscriber::Interest;
@@ -175,33 +175,6 @@ async fn start_lsp_proxy(
     }
 }
 
-pub(crate) fn read_most_recent_log_file(
-    log_path: Option<PathBuf>,
-    log_file_name_prefix: String,
-) -> io::Result<Option<String>> {
-    let pgt_log_path = log_path.unwrap_or(default_pgt_log_path());
-
-    let most_recent = fs::read_dir(pgt_log_path)?
-        .flatten()
-        .filter(|file| file.file_type().is_ok_and(|ty| ty.is_file()))
-        .filter_map(|file| {
-            match file
-                .file_name()
-                .to_str()?
-                .split_once(log_file_name_prefix.as_str())
-            {
-                Some((_, date_part)) if date_part.split('-').count() == 4 => Some(file.path()),
-                _ => None,
-            }
-        })
-        .max();
-
-    match most_recent {
-        Some(file) => Ok(Some(fs::read_to_string(file)?)),
-        None => Ok(None),
-    }
-}
-
 /// Set up the [tracing]-based logging system for the server
 /// The events received by the subscriber are filtered at the `info` level,
 /// then printed using the [HierarchicalLayer] layer, and the resulting text

crates/pgt_cli/src/commands/check.rs

@@ -15,7 +15,6 @@ use pgt_workspace::workspace::UpdateSettingsParams;
 use pgt_workspace::{DynRef, Workspace, WorkspaceError};
 use std::ffi::OsString;
 use std::path::PathBuf;
-
 pub(crate) mod check;
 pub(crate) mod clean;
 pub(crate) mod daemon;
@@ -24,6 +23,7 @@ pub(crate) mod version;
 
 #[derive(Debug, Clone, Bpaf)]
 #[bpaf(options, version(VERSION))]
+#[allow(clippy::large_enum_variant)]
 /// Postgres Tools official CLI. Use it to check the health of your project or run it to check single files.
 pub enum PgtCommand {
     /// Shows the version information and quit.
@@ -338,9 +338,6 @@ pub(crate) trait CommandRunner: Sized {
     /// It returns the file path to use in `stdin` mode.
     fn get_stdin_file_path(&self) -> Option<&str>;
 
-    /// Whether the command should write the files.
-    fn should_write(&self) -> bool;
-
     /// Returns the [Execution] mode.
     fn get_execution(
         &self,
@@ -357,11 +354,6 @@ pub(crate) trait CommandRunner: Sized {
     fn check_incompatible_arguments(&self) -> Result<(), CliDiagnostic> {
         Ok(())
     }
-
-    /// Checks whether the configuration has errors.
-    fn should_validate_configuration_diagnostics(&self) -> bool {
-        true
-    }
 }
 
 fn get_files_to_process_with_cli_options(