fix: review

Author: psteinroe

crates/pglt_lexer/src/diagnostics.rs

@@ -59,5 +59,9 @@ mod tests {
             "select 1443ddwwd33djwdkjw13331333333333; select 1443ddwwd33djwdkjw13331333333333;";
         let diagnostics = lex(input).unwrap_err();
         assert_eq!(diagnostics.len(), 2);
+        assert_eq!(diagnostics[0].span.unwrap().start(), 7.into());
+        assert_eq!(diagnostics[0].span.unwrap().end(), 39.into());
+        assert_eq!(diagnostics[1].span.unwrap().start(), 48.into());
+        assert_eq!(diagnostics[1].span.unwrap().end(), 80.into());
     }
 }

crates/pglt_workspace/src/workspace/server/change.rs

@@ -103,11 +103,7 @@ impl Document {
         self.diagnostics = diagnostics;
 
         // Do not add any statements if there is a fatal error
-        if self
-            .diagnostics
-            .iter()
-            .any(|d| d.severity() == pglt_diagnostics::Severity::Fatal)
-        {
+        if self.has_fatal_error() {
             return changes;
         }
 
@@ -264,11 +260,7 @@ impl Document {
 
             self.diagnostics = diags;
 
-            if self
-                .diagnostics
-                .iter()
-                .any(|d| d.severity() == pglt_diagnostics::Severity::Fatal)
-            {
+            if self.has_fatal_error() {
                 // cleanup all positions if there is a fatal error
                 changed.extend(self.drain_positions());
                 // still process text change
@@ -333,11 +325,7 @@ impl Document {
 
         self.diagnostics = diags;
 
-        if self
-            .diagnostics
-            .iter()
-            .any(|d| d.severity() == pglt_diagnostics::Severity::Fatal)
-        {
+        if self.has_fatal_error() {
             // cleanup all positions if there is a fatal error
             changed.extend(self.drain_positions());
             // still process text change