fix: do not shower hover info on sql params

Author: juleswritescode

crates/pgt_hover/src/lib.rs

@@ -25,12 +25,16 @@ pub struct OnHoverParams<'a> {
     position = params.position.to_string()
 ))]
 pub fn on_hover(params: OnHoverParams) -> Vec<String> {
+    println!("on hover!");
+
     let ctx = pgt_treesitter::context::TreesitterContext::new(TreeSitterContextParams {
         position: params.position,
         text: params.stmt_sql,
         tree: params.ts_tree,
     });
 
+    println!("ctx {:#?}", ctx);
+
     if let Some(hovered_node) = HoveredNode::get(&ctx) {
         let items: Vec<Hoverable> = match hovered_node {
             HoveredNode::Table(node_identification) => match node_identification {

crates/pgt_hover/tests/hover_integration_tests.rs

@@ -518,3 +518,44 @@ async fn test_grant_table_hover(test_db: PgPool) {
 
     test_hover_at_cursor("grant_select", query, None, &test_db).await;
 }
+
+#[sqlx::test(migrator = "pgt_test_utils::MIGRATIONS")]
+async fn no_hover_results_over_params(test_db: PgPool) {
+    let setup = r#"
+        create table users (
+            id serial primary key,
+            name text
+        );
+    "#;
+
+    test_db.execute(setup).await.unwrap();
+
+    {
+        let query = format!(
+            "select * from users where name = $n{}ame;",
+            QueryWithCursorPosition::cursor_marker()
+        );
+        test_hover_at_cursor("$-param", query, None, &test_db).await;
+    }
+    {
+        let query = format!(
+            "select * from users where name = :n{}ame;",
+            QueryWithCursorPosition::cursor_marker()
+        );
+        test_hover_at_cursor(":-param", query, None, &test_db).await;
+    }
+    {
+        let query = format!(
+            "select * from users where name = @n{}ame;",
+            QueryWithCursorPosition::cursor_marker()
+        );
+        test_hover_at_cursor("@-param", query, None, &test_db).await;
+    }
+    {
+        let query = format!(
+            "select * from users where name = ?n{}ame;",
+            QueryWithCursorPosition::cursor_marker()
+        );
+        test_hover_at_cursor("?-param", query, None, &test_db).await;
+    }
+}

crates/pgt_hover/tests/snapshots/$-param.snap

@@ -0,0 +1,12 @@
+---
+source: crates/pgt_hover/tests/hover_integration_tests.rs
+expression: snapshot
+---
+# Input
+```sql
+select * from users where name = $name;
+                                   ↑ hovered here
+```
+
+# Hover Results
+No hover information found.

crates/pgt_hover/tests/snapshots/:-param.snap

@@ -0,0 +1,12 @@
+---
+source: crates/pgt_hover/tests/hover_integration_tests.rs
+expression: snapshot
+---
+# Input
+```sql
+select * from users where name = :name;
+                                   ↑ hovered here
+```
+
+# Hover Results
+No hover information found.

crates/pgt_hover/tests/snapshots/?-param.snap

@@ -0,0 +1,12 @@
+---
+source: crates/pgt_hover/tests/hover_integration_tests.rs
+expression: snapshot
+---
+# Input
+```sql
+select * from users where name = ?name;
+                                   ↑ hovered here
+```
+
+# Hover Results
+No hover information found.

crates/pgt_hover/tests/snapshots/@-param.snap

@@ -0,0 +1,12 @@
+---
+source: crates/pgt_hover/tests/hover_integration_tests.rs
+expression: snapshot
+---
+# Input
+```sql
+select * from users where name = @name;
+                                   ↑ hovered here
+```
+
+# Hover Results
+No hover information found.

crates/pgt_treesitter_grammar/grammar.js

@@ -3378,10 +3378,10 @@ module.exports = grammar({
       choice(
         $._identifier,
         $._double_quote_string,
-        $._tsql_parameter,
+        $._sql_parameter,
         seq("`", $._identifier, "`")
       ),
-    _tsql_parameter: ($) => seq("@", $._identifier),
+    _sql_parameter: (_) => /[:$@?][a-zA-Z_][0-9a-zA-Z_]*/,
     _identifier: (_) => /[a-zA-Z_][0-9a-zA-Z_]*/,
   },
 });