Skip to content

Commit e04113a

Browse files
authored
Merge pull request #10 from sunsided/feature/write_str
Replace write! with write_char
2 parents d7412b6 + 96d9042 commit e04113a

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
All notable changes to this project will be documented in this file.
44
This project uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6+
## Unreleased
7+
8+
### Internal
9+
10+
- `write_char()` and `fmt()` calls are now used instead of `write!` when rendering the string.
11+
612
## [0.5.0] - 2024-05-24
713

814
[0.5.0]: https://github.com/sunsided/query-string-builder/releases/tag/v0.5.0

src/lib.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
2323
#![deny(unsafe_code)]
2424

25-
use std::fmt::{Debug, Display, Formatter};
25+
use std::fmt::{Debug, Display, Formatter, Write};
2626

2727
use percent_encoding::{utf8_percent_encode, AsciiSet, CONTROLS};
2828

@@ -230,17 +230,15 @@ impl Display for QueryString {
230230
if self.pairs.is_empty() {
231231
Ok(())
232232
} else {
233-
write!(f, "?")?;
233+
f.write_char('?')?;
234234
for (i, pair) in self.pairs.iter().enumerate() {
235235
if i > 0 {
236-
write!(f, "&")?;
236+
f.write_char('&')?;
237237
}
238-
write!(
239-
f,
240-
"{key}={value}",
241-
key = utf8_percent_encode(&pair.key, QUERY),
242-
value = utf8_percent_encode(&pair.value, QUERY)
243-
)?;
238+
239+
utf8_percent_encode(&pair.key, QUERY).fmt(f)?;
240+
f.write_char('=')?;
241+
utf8_percent_encode(&pair.value, QUERY).fmt(f)?;
244242
}
245243
Ok(())
246244
}

0 commit comments

Comments
 (0)