Clippy --fix (I'm lame)

Author: Marcondiro

src/block/decoder.rs

@@ -59,7 +59,7 @@ mod test {
 ///
 /// * `T` - The Callback Closure Type in the Config
 pub struct BlockDecoder<'a, T>(&'a mut pt_block_decoder, PhantomData<T>);
-impl<'a, T> BlockDecoder<'a, T> {
+impl<T> BlockDecoder<'_, T> {
     /// Allocate an Intel PT block decoder.
     ///
     /// The decoder will work on the buffer defined in @config,
@@ -217,7 +217,7 @@ impl<'a, T> BlockDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Iterator for BlockDecoder<'a, T> {
+impl<T> Iterator for BlockDecoder<'_, T> {
     type Item = Result<(Block, Status), PtError>;
 
     fn next(&mut self) -> Option<Result<(Block, Status), PtError>> {
@@ -229,7 +229,7 @@ impl<'a, T> Iterator for BlockDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Drop for BlockDecoder<'a, T> {
+impl<T> Drop for BlockDecoder<'_, T> {
     fn drop(&mut self) {
         unsafe { pt_blk_free_decoder(self.0) }
     }

src/config/config.rs

@@ -196,13 +196,13 @@ impl<'a, T> ConfigBuilder<'a, T> {
         where F: FnMut(&Config<T>, &[u8]) -> (Unknown<T>, u32),
               F: 'a {
         // yeah.. libipt doesnt handle this -_-
-        if buf.len() < 1 { return Err(
+        if buf.is_empty() { return Err(
             PtError::new(PtErrorCode::Invalid, "buffer cant be empty!")
         )}
         let mut cfg: pt_config = unsafe { mem::zeroed() };
         cfg.size  = mem::size_of::<pt_config>();
         cfg.begin = buf.as_mut_ptr();
-        cfg.end   = unsafe { buf.as_mut_ptr().offset(buf.len() as isize) };
+        cfg.end   = unsafe { buf.as_mut_ptr().add(buf.len()) };
         cfg.decode.callback = Some(decode_callback::<F, T>);
         cfg.decode.context  = &mut cb as *mut _ as *mut c_void;
         Ok(ConfigBuilder::<T>(cfg, PhantomData))
@@ -252,13 +252,13 @@ impl<'a> ConfigBuilder<'a, ()> {
     /// use the `with_callback` function
     /// returns `Invalid` when buf is empty
     pub fn new(buf: &'a mut [u8]) -> Result<ConfigBuilder<'a, ()>, PtError> {
-        if buf.len() < 1 { return Err(
+        if buf.is_empty() { return Err(
             PtError::new(PtErrorCode::Invalid, "buffer cant be empty!")
         )}
         let mut cfg: pt_config = unsafe { mem::zeroed() };
         cfg.size  = mem::size_of::<pt_config>();
         cfg.begin = buf.as_mut_ptr();
-        cfg.end   = unsafe { buf.as_mut_ptr().offset(buf.len() as isize) };
+        cfg.end   = unsafe { buf.as_mut_ptr().add(buf.len()) };
         Ok(ConfigBuilder::<()>(cfg, PhantomData))
     }
 }

src/config/filter.rs

@@ -115,6 +115,12 @@ impl AddrFilter {
 }
 
 pub struct AddrFilterBuilder (pub(super) pt_conf_addr_filter);
+impl Default for AddrFilterBuilder {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl AddrFilterBuilder {
     pub fn new() -> Self { unsafe { mem::zeroed() }}
 

src/event/qry.rs

@@ -77,7 +77,7 @@ pub enum CondBranch {
 /// it shall contain raw trace data and remain valid for the lifetime of the decoder.
 /// The decoder needs to be synchronized before it can be used.
 pub struct QueryDecoder<'a, T>(&'a mut pt_query_decoder, PhantomData<T>);
-impl<'a, T> QueryDecoder<'a, T> {
+impl<T> QueryDecoder<'_, T> {
     /// Allocate an Intel PT query decoder.
     ///
     /// The decoder will work on the buffer defined in @config,
@@ -246,7 +246,7 @@ impl<'a, T> QueryDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Iterator for QueryDecoder<'a, T> {
+impl<T> Iterator for QueryDecoder<'_, T> {
     type Item = Result<(Event, Status), PtError>;
 
     fn next(&mut self) -> Option<Result<(Event, Status), PtError>> {
@@ -258,6 +258,6 @@ impl<'a, T> Iterator for QueryDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Drop for QueryDecoder<'a, T> {
+impl<T> Drop for QueryDecoder<'_, T> {
     fn drop(&mut self) { unsafe { pt_qry_free_decoder(self.0) }}
 }

src/flags.rs

@@ -9,11 +9,11 @@ bitflags! {
     /// Status flags for various IntelPT actions
     pub struct Status: u32 {
         /// There is no more trace data available.
-        const EOS = pt_status_flag_pts_eos as u32;
+        const EOS = pt_status_flag_pts_eos;
         /// There is an event pending.
-        const EVENT_PENDING = pt_status_flag_pts_event_pending as u32;
+        const EVENT_PENDING = pt_status_flag_pts_event_pending;
         /// The address has been suppressed.
-        const IP_SUPRESSED  = pt_status_flag_pts_ip_suppressed as u32;
+        const IP_SUPRESSED  = pt_status_flag_pts_ip_suppressed;
     }
 }
 

src/image/image.rs

@@ -237,7 +237,7 @@ pub struct Image<'a> {
     callback: Option<BoxedCallback>,
 }
 
-impl<'a> Image<'a> {
+impl Image<'_> {
     /// Allocate a traced memory image.
     /// An optional @name may be given to the image.
     /// The name string is copied.
@@ -398,7 +398,7 @@ impl<'a> From<&'a mut pt_image> for Image<'a> {
     }
 }
 
-impl<'a> Drop for Image<'a> {
+impl Drop for Image<'_> {
     fn drop(&mut self) {
         if self.dealloc {
             unsafe { pt_image_free(self.inner) }

src/image/iscache.rs

@@ -83,7 +83,7 @@ mod test {
 /// A cache of traced image sections.
 #[derive(Debug)]
 pub struct SectionCache<'a>(pub(crate) &'a mut pt_image_section_cache);
-impl<'a> SectionCache<'a> {
+impl SectionCache<'_> {
     /// Allocate a traced memory image section cache.
     ///
     /// An optional @name may be given to the cache.
@@ -97,7 +97,7 @@ impl<'a> SectionCache<'a> {
                     PtErrorCode::Invalid,
                     "invalid @name string: contains null bytes")
                 )?.as_ptr())
-        }}).map(|s| SectionCache(s))
+        }}).map(SectionCache)
     }
 
     /// Get the image section cache name.
@@ -146,8 +146,8 @@ impl<'a> SectionCache<'a> {
     /// Returns number of bytes read on success.
     /// Returns Nomap if @vaddr is not contained in section @isid.
     /// Returns BadImage if @iscache does not contain @isid.
-    pub fn read<'b>(&mut self,
-                    buffer: &'b mut [u8],
+    pub fn read(&mut self,
+                    buffer: &mut [u8],
                     isid: u32,
                     vaddr: u64) -> Result<u32, PtError> {
        extract_pterr(unsafe {
@@ -169,7 +169,7 @@ impl<'a> SectionCache<'a> {
     }
 }
 
-impl<'a> Drop for SectionCache<'a> {
+impl Drop for SectionCache<'_> {
     fn drop(&mut self) {
         unsafe { pt_iscache_free(self.0) }
     }

src/insn/decoder.rs

@@ -79,7 +79,7 @@ mod test {
 /// it shall contain raw trace data and remain valid for the lifetime of the decoder.
 /// The decoder needs to be synchronized before it can be used.
 pub struct InsnDecoder<'a, T>(&'a mut pt_insn_decoder, PhantomData<T>);
-impl<'a, T> InsnDecoder<'a, T> {
+impl<T> InsnDecoder<'_, T> {
     /// Allocate an Intel PT instruction flow decoder.
     ///
     /// The decoder will work on the buffer defined in @config,
@@ -253,7 +253,7 @@ impl<'a, T> InsnDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Iterator for InsnDecoder<'a, T> {
+impl<T> Iterator for InsnDecoder<'_, T> {
     type Item = Result<(Insn, Status), PtError>;
 
     fn next(&mut self) -> Option<Result<(Insn, Status), PtError>> {
@@ -265,6 +265,6 @@ impl<'a, T> Iterator for InsnDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Drop for InsnDecoder<'a, T> {
+impl<T> Drop for InsnDecoder<'_, T> {
     fn drop(&mut self) { unsafe { pt_insn_free_decoder(self.0) } }
 }

src/packet/decoder.rs

@@ -55,7 +55,7 @@ mod test {
 }
 
 pub struct PacketDecoder<'a, T>(&'a mut pt_packet_decoder, PhantomData<T>);
-impl<'a, T> PacketDecoder<'a, T> {
+impl<T> PacketDecoder<'_, T> {
     /// Allocate an Intel PT packet decoder.
     ///
     /// The decoder will work on the buffer defined in @config,
@@ -131,7 +131,7 @@ impl<'a, T> PacketDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Iterator for PacketDecoder<'a, T> {
+impl<T> Iterator for PacketDecoder<'_, T> {
     type Item = Result<Packet<T>, PtError>;
 
     fn next(&mut self) -> Option<Result<Packet<T>, PtError>> {
@@ -143,6 +143,6 @@ impl<'a, T> Iterator for PacketDecoder<'a, T> {
     }
 }
 
-impl<'a, T> Drop for PacketDecoder<'a, T> {
+impl<T> Drop for PacketDecoder<'_, T> {
     fn drop(&mut self) { unsafe { pt_pkt_free_decoder(self.0) }}
 }

src/packet/encoder.rs

@@ -48,7 +48,7 @@ mod tests {
 }
 
 pub struct Encoder<'a, T>(&'a mut pt_encoder, PhantomData<T>);
-impl<'a, T> Encoder<'a, T> {
+impl<T> Encoder<'_, T> {
     /// Allocate an Intel PT packet encoder.
     ///
     /// The encoder will work on the buffer defined in @config, it shall contain raw trace data and remain valid for the lifetime of the encoder.
@@ -97,6 +97,6 @@ impl<'a, T> Encoder<'a, T> {
     }
 }
 
-impl<'a, T> Drop for Encoder<'a, T> {
+impl<T> Drop for Encoder<'_, T> {
     fn drop(&mut self) { unsafe { pt_free_encoder(self.0) } }
 }