From ef982e4f8aacd66c9a685f31aec71466a1f11a58 Mon Sep 17 00:00:00 2001 From: janniks Date: Wed, 12 Feb 2025 22:32:14 +0800 Subject: [PATCH 1/2] chore: add todo --- packages/transactions/src/namespaces/address.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/transactions/src/namespaces/address.ts b/packages/transactions/src/namespaces/address.ts index 960243892..112f9b6cb 100644 --- a/packages/transactions/src/namespaces/address.ts +++ b/packages/transactions/src/namespaces/address.ts @@ -39,7 +39,8 @@ export function parse( | ContractIdString ): AddressRepr { const [addr, contractName] = address.split('.'); - const parsed = c32addressDecode(addr); + const parsed = c32addressDecode(addr); // throws if c32 part is invalid + // todo: throw if contract name is invalid return { version: parsed[0], versionChar: C32[parsed[0]], From 08e699e003a7afb22ff40bea73cb4dc9ccc85a09 Mon Sep 17 00:00:00 2001 From: janniks Date: Wed, 12 Feb 2025 22:34:42 +0800 Subject: [PATCH 2/2] fix: Improve Address.parse helper types --- packages/transactions/src/namespaces/address.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/transactions/src/namespaces/address.ts b/packages/transactions/src/namespaces/address.ts index 112f9b6cb..8c5c99bc1 100644 --- a/packages/transactions/src/namespaces/address.ts +++ b/packages/transactions/src/namespaces/address.ts @@ -37,7 +37,7 @@ export function parse( | AddressString // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents | ContractIdString -): AddressRepr { +): Required { const [addr, contractName] = address.split('.'); const parsed = c32addressDecode(addr); // throws if c32 part is invalid // todo: throw if contract name is invalid @@ -45,7 +45,7 @@ export function parse( version: parsed[0], versionChar: C32[parsed[0]], hash160: parsed[1], - contractName: contractName, + contractName, }; }