Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Commit 13d208f

Browse files
DateRangeFilter overwrites other filter
2 parents 6a19724 + d5563b0 commit 13d208f

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# Version 1.1.1
2+
3+
* Bugfix: DateRangeFilter overwrites other filter (#803)
4+
15
# Version 1.1.0
26

37
* Dropped support for PHP 5 and PHP 7.0. (#850)

Datatable/Filter/AbstractFilter.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ protected function getExpression(Composite $expr, QueryBuilder $qb, $searchType,
373373
case 'decimal':
374374
case 'float':
375375
if (is_numeric($searchValue)) {
376-
$searchValue = floatval($searchValue);
376+
$searchValue = (float) $searchValue;
377377
} else {
378378
$incompatibleTypeOfField = true;
379379
}
@@ -382,8 +382,8 @@ protected function getExpression(Composite $expr, QueryBuilder $qb, $searchType,
382382
case 'bigint':
383383
case 'smallint':
384384
case 'boolean':
385-
if ($searchValue == strval(intval($searchValue))) {
386-
$searchValue = intval($searchValue);
385+
if ( $searchValue == (string) (int) $searchValue ) {
386+
$searchValue = (int) $searchValue;
387387
} else {
388388
$incompatibleTypeOfField = true;
389389
}
@@ -465,6 +465,8 @@ protected function getExpression(Composite $expr, QueryBuilder $qb, $searchType,
465465
*/
466466
protected function getBetweenAndExpression(Andx $andExpr, QueryBuilder $qb, $searchField, $from, $to, $parameterCounter)
467467
{
468+
$parameterCounter++;
469+
468470
$k = $parameterCounter + 1;
469471
$andExpr->add($qb->expr()->between($searchField, '?'.$parameterCounter, '?'.$k));
470472
$qb->setParameter($parameterCounter, $from);

0 commit comments

Comments
 (0)