Merge pull request #259 from jafin/fix/build-warnings

refactor: Fix build warnings

Author: ststeiger

PdfSharpCore/Drawing/XGlyphTypeface.cs

@@ -68,12 +68,23 @@ public XGlyphTypeface(string key, XFontSource fontSource)
             Initialize();
         }
 
+        // ReSharper disable once UnusedMember.Global
+        public XGlyphTypeface(string key, XFontFamily fontFamily, XFontSource fontSource, XStyleSimulations styleSimulations)
+        {
+            _key = key;
+            _fontFamily = fontFamily;
+            _fontSource = fontSource;
+            _styleSimulations = styleSimulations;
+            _fontface = OpenTypeFontface.CetOrCreateFrom(fontSource);
+
+            Initialize();
+        }
+
         public static XGlyphTypeface GetOrCreateFrom(string familyName, FontResolvingOptions fontResolvingOptions)
         {
             // Check cache for requested type face.
             string typefaceKey = ComputeKey(familyName, fontResolvingOptions);
-            XGlyphTypeface glyphTypeface;
-            if (GlyphTypefaceCache.TryGetGlyphTypeface(typefaceKey, out glyphTypeface))
+            if (GlyphTypefaceCache.TryGetGlyphTypeface(typefaceKey, out var glyphTypeface))
             {
                 // Just return existing one.
                 return glyphTypeface;
@@ -88,8 +99,7 @@ public static XGlyphTypeface GetOrCreateFrom(string familyName, FontResolvingOpt
             }
             // Now create the font family at the first.
             XFontFamily fontFamily;
-            PlatformFontResolverInfo platformFontResolverInfo = fontResolverInfo as PlatformFontResolverInfo;
-            if (platformFontResolverInfo != null)
+            if (fontResolverInfo is PlatformFontResolverInfo platformFontResolverInfo)
             {
             }
             else

PdfSharpCore/Drawing/XGraphics.cs

@@ -123,10 +123,6 @@ public sealed class XGraphics : IDisposable
         }
         XGraphics(XSize size, XGraphicsUnit pageUnit, XPageDirection pageDirection)
         {
-            if (size == null)
-                throw new ArgumentNullException("size");
-            
-
             _gsStack = new GraphicsStateStack(this);
             _pageSizePoints = new XSize(size.Width, size.Height);
             switch (pageUnit)