draft: feat(backend/sdoc_source_code): Allow empty lines in source node fields #2554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, finding a static merge candidate for source nodes relied on having a UID field set at source code side. Now we can also use MIDs for this purpose. Merge by MID gets priority over merge merge by UID. This requires thinking about several edge cases. See test desriptions for some of them.
Previously, a source node field was terminated at the first empty line. A workaround existed where adding literal \n\n was translated to new line. This removes the workaround and introduces a more user friendly way, where empty lines don't terminate a field. Instead, either the next field marker or a reserved termination word ends the field. Comment grammar didn't change much. Most notaly newlines that belong to field text are now part of the parse tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a source node field was terminated at the first empty line. A workaround existed where adding literal
\n\nwas translated to new line.This change removes the workaround and introduces a more user friendly rule where empty lines are kept as part of a field. To terminate the field we can either simply start the next field, or insert a reserved termination word that ends the field preliminary.
Comment grammar didn't change much. Most notably newlines that belong to field text are now part of the parse tree.
TODO: