TOC highlighting refactor and robustness fixes #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mettta
commented
Aug 28, 2025
mettta
commented
- Simplified and cleaned guards: removed redundant checks, unified coordinate comparisons in IntersectionObserver, simplified hash extraction.
- Robustness improvements: added viewport fallback for rootBounds=null, replaced silent guards with console.assert and moved checks to call sites.
- Efficient re-scan: introduced anchorsCount/anchorsSig to detect TOC mutations and skip unnecessary re-observe, while keeping mapping valid after resetState().
- Removed legacy code: dropped unused contentFrameTop metric and clarified inline comments.
- Hash remapping: implemented resolveMovedFragment() to transparently remap outdated hashes when TOC entries are reordered and renumbered.
…valid - Introduced anchorsCount/anchorsSig to detect changes and avoid redundant re-observe. - Rebuild anchor→data mapping after resetState() even if set unchanged. - Guarded handleIntersect against missing mapping during TOC mutations.
…ve checks to call sites
…hashes after TOC reorder
stanislaw
reviewed
Aug 28, 2025
| if (!element) { return } // Guard against race conditions | ||
| // * Toggle "parented" attribute for section folders. | ||
|
|
||
| //// Guard against race conditions |
Collaborator
There was a problem hiding this comment.
As discussed, let's not forget to remove this.
stanislaw
reviewed
Aug 28, 2025
| // * Toggle "intersected" attribute for visible anchors. | ||
|
|
||
| //// Guard: events may fire before TOC is fully built. | ||
| ////// Guard against race conditions |
Collaborator
There was a problem hiding this comment.
As discussed, let's not forget to remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.